WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#26249 closed defect (bug) (fixed)

Include Nginx reference in PHPDoc head of /wp-includes/vars.php

Reported by: netweb Owned by:
Milestone: 3.9 Priority: normal
Severity: minor Version: 3.7
Component: Permalinks Keywords: has-patch commit
Focuses: docs Cc:

Description

Add a reference to Nginx as one of three known servers that are detected by WordPress.

​http://core.trac.wordpress.org/browser/trunk/src/wp-includes/vars.php#L89

Attachments (3)

vars.php.diff​ (581 bytes) - added by netweb 4 years ago.
26249.diff​ (775 bytes) - added by DrewAPicture 4 years ago.
26249.2.diff​ (715 bytes) - added by markjaquith 4 years ago.

Download all attachments as: .zip

Change History (10)

@netweb
4 years ago

#1 @SergeyBiryukov
4 years ago

Three web servers with known permalink capability.

It's probably worth noting that we don't write or suggest nginx configuration for permalinks (see [25456] for #25098).

#2 @SergeyBiryukov
4 years ago

  • Version changed from trunk to 3.7

@DrewAPicture
4 years ago

#3 @DrewAPicture
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9

26249.diff​ attempts to incorporate @SergeyBiryukov's feedback from comment:2. Feedback is welcome, otherwise it looks good to me.

@markjaquith
4 years ago

#4 follow-up: @markjaquith
4 years ago

Simplified DrewAPicture's addition, referenced Codex which has these rules.

#5 in reply to: ↑ 4 @DrewAPicture
4 years ago

Replying to markjaquith:

Simplified DrewAPicture's addition, referenced Codex which has these rules.

+1 for 26249.2.diff​

#6 @DrewAPicture
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [26931]

#7 @DrewAPicture
3 years ago

  • Component changed from Inline Docs to Permalinks
  • Focuses docs added
Note: See TracTickets for help on using tickets.