WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26253 closed defect (bug) (fixed)

Hook Docs (22): wp-includes/feed.php

Reported by: stevenkword's profile stevenkword Owned by: drewapicture's profile DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch commit
Focuses: docs Cc:

Description


Attachments (6)

26253.diff​ (8.1 KB) - added by stevenkword 11 years ago.
26253.2.diff​ (8.1 KB) - added by stevenkword 11 years ago.
Whitespace and capitalization fixes.
26253.3.diff​ (8.0 KB) - added by stevenkword 11 years ago.
Re-adds line breaks.
26253.4.diff​ (12.2 KB) - added by DrewAPicture 11 years ago.
Complete pass
26253.5.diff​ (13.0 KB) - added by kpdesign 11 years ago.
Second pass on 26253.4.diff
26253.6.diff​ (12.6 KB) - added by DrewAPicture 11 years ago.
Final pass.

Download all attachments as: .zip

Change History (17)

#1 @stevenkword
11 years ago

Still working on this one. I was temporarily slowed down by #26252, but I am back on top of things and I should have this ticket completed within the next few days.

Last edited 11 years ago by SergeyBiryukov (previous) (diff)

@stevenkword
11 years ago

#2 @stevenkword
11 years ago

  • Keywords has-patch added; needs-patch removed

@stevenkword
11 years ago

Whitespace and capitalization fixes.

@stevenkword
11 years ago

Re-adds line breaks.

#3 @DrewAPicture
11 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing
  • Summary changed from Hook Docs: wp-includes/feed.php to Hook Docs (22): wp-includes/feed.php

Hi, thanks for the patch. I'll get you a review on this soon.

#4 @stevenkword
11 years ago

Sounds good. I see a few smallish things that I could make more clear, but I'm going to hold off for now.

@DrewAPicture
11 years ago

Complete pass

#5 @DrewAPicture
11 years ago

26253.4.diff​ is a full pass, which includes tightening up some descriptions and fixing a few doc-specific variable issues. It's ready for secondary review.

@kpdesign
11 years ago

Second pass on 26253.4.diff

#6 @kpdesign
11 years ago

26253.5.diff​ is a second pass on @DrewAPicture's patch. Changed some docs-specific variables, and a few @since values. Should be pretty close with this one.

Needs a review and a recommendation.

@DrewAPicture
11 years ago

Final pass.

#7 @DrewAPicture
11 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9

26253.6.diff​ should cover it.

#8 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26902:

Inline documentation for hooks in wp-includes/feed.php.

Props stevenkword, kpdesign, DrewAPicture.
Fixes #26253.

#9 @SergeyBiryukov
11 years ago

In 26903:

Correct @since values. see #26253.

#10 @DrewAPicture
11 years ago

  • Focuses docs added

#11 @DrewAPicture
11 years ago

  • Component changed from Inline Docs to Feeds
Note: See TracTickets for help on using tickets.