Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26261 closed defect (bug) (fixed)

Misaligned buttons when editing a post slug

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords:
Focuses: ui Cc:

Description

See the screenshot.

Attachments (2)

26261.png (7.0 KB) - added by SergeyBiryukov 11 years ago.
26261.diff (1.2 KB) - added by mattheu 11 years ago.

Download all attachments as: .zip

Change History (4)

@SergeyBiryukov
11 years ago

@mattheu
11 years ago

#1 @mattheu
11 years ago

I looked into this bug and noticed a couple of issues.

  • The new input field styles are too large in this context. This causes alignment issues with the buttons, and also the the height of the #edit-slug-box is larger when the input is visible, causing a jump in the page when showing/hiding the input.
  • The button-small styles are a little inconsistent across the admin. Within the colorpicker on the theme customizer, they have a smaller font, and larger height.

I have added a patch that

  1. Reduces the size of the edit permalink input, and reduces the font size to match the label text. This is a 1 off style for this input.
  2. Move the styles from .wp-picker-input-wrap .button.button-small and apply to all .button-small

This makes everything line up a bit nicer. See screenshot.

https://dl.dropboxusercontent.com/s/hdeepjzurjp0o06/2013-11-26%20at%2016.05.png

There are a couple of other places in the admin that the button-small class is used, but I tested them and there are no issues created by making this change. They are as follows:

  • In the taxonomy search field on the menu edit page. But this is hidden.
  • On the press this field when adding an image. But this still looks fine.

#2 @iammattthomas
11 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26420:

Unify the style of button-small everywhere we use it, and make sure the edit slug input lines up with its button and label. Fixes #26261, props mattheu.

Note: See TracTickets for help on using tickets.