WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26272 closed defect (bug) (fixed)

File organisation checkbox is incorrectly bold on options-media.php, as per current label element style

Reported by: Hanni Owned by: iammattthomas
Milestone: 3.8 Priority: normal
Severity: minor Version: 3.8
Component: Administration Keywords: needs-patch needs-ui
Focuses: ui Cc:

Description

There's a new label element "Organize my uploads into month- and year-based folders", which is emboldened on options-reading.php, but this doesn't make much sense in this case.

When a label element appears inside of th.th-full, the font-weight should be set to normal.

Enclosed screenshot.

Attachments (2)

Screen Shot 2013-11-26 at 18.08.04.png (20.4 KB) - added by Hanni 6 years ago.
26272.diff (716 bytes) - added by Ipstenu 6 years ago.
Change th to td?

Download all attachments as: .zip

Change History (7)

#1 @Hanni
6 years ago

  • Severity changed from normal to minor

@Ipstenu
6 years ago

Change th to td?

#2 @Ipstenu
6 years ago

Looks like this comes from the styling of th.

If changed to td, it looks better but I don't know if that's the right call here. The other would be to make a change to the stylings from MP6 to not always bolden.

#3 @SergeyBiryukov
6 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

#4 @iammattthomas
6 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26436:

Give th.th-full font-weight: 400 so its label doesn't get emboldened. Fixes #26272.

#5 @iammattthomas
6 years ago

I decided to fix this one by resetting the font weight of .form-table th.th-full so we can use td or th, whatever's semantically appropriate.

Note: See TracTickets for help on using tickets.