WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26276 closed defect (bug) (fixed)

Welcome panel does not check theme support for current theme

Reported by: MikeHansenMe Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.3
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

On the dashboard when the welcome screen shows. It shows "Manage widgets or menus." If the theme does not support widgets the widget link goes to an error page that shows "The theme you are currently using isn’t widget-aware...". If the theme does not support menus the menu link will still take you to the nav-menus.php page(which does not show in the nav) but it is fairly useless. If you click "Add new menu" it send you to an error page. I think it would be best to stop users before they get to an error or page to confuse them more.

Related #25949

Attachments (2)

welcome-theme-support.diff (1.9 KB) - added by MikeHansenMe 6 years ago.
check for theme support
26276.diff (1.8 KB) - added by obenland 6 years ago.

Download all attachments as: .zip

Change History (5)

@MikeHansenMe
6 years ago

check for theme support

#1 @MikeHansenMe
6 years ago

So the menu link just takes you to a error page as well. I had added a menu while testing that allowed me to access the page.

@obenland
6 years ago

#2 @obenland
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.9
  • Version set to 3.3

Nice catch Mike

#3 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27563:

Cap and theme support checks for the welcome panel.

props MikeHansenMe.
fixes #26276.

Note: See TracTickets for help on using tickets.