Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26289 closed defect (bug) (fixed)

Color Picker bugs.

Reported by: mattheu's profile mattheu Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

  1. .wp-color-result.wp-picker-open has top: 0, causing a 1px jump when opening/closing.
  2. in the new 3.8 UI - the text in the field is larger and overflows the fixed with of this field. It would be nicer to reduce the text size so it fits.

https://dl.dropboxusercontent.com/s/zkntppcnj69hnet/2013-11-27%20at%2014.40.png

  1. When used outside of the theme customizer, the input field .wp-color-picker has no styling.

https://dl.dropboxusercontent.com/s/tjcztv7t7bkalet/2013-11-27%20at%2014.25.png

To recreate 3. Create a text input and use the JS like so: jQuery('input.my-colorpicker').wpColorPicker();

This patch

  1. applies top: 0 to .wp-color-result(open and closed)
  2. Reduces text size in hex-value field
  3. Moves hex-value-field styles to main customizer styles.

Attachments (1)

26289.diff (1.8 KB) - added by mattheu 11 years ago.

Download all attachments as: .zip

Change History (3)

@mattheu
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Component changed from General to Appearance
  • Keywords ui-focus has-patch added
  • Milestone changed from Awaiting Review to 3.8

#2 @iammattthomas
11 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26435:

Design fixes to the color picker:

  • Apply top: 0 to .wp-color-result (open and closed).
  • Reduce text size in hex-value field.
  • Move hex-value-field styles to color-picker.css.

Fixes #26289, props mattheu.

Note: See TracTickets for help on using tickets.