Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26305 closed defect (bug) (fixed)

Themes: messages (deleting or activating a theme) are being rendered at the bottom

Reported by: matveb's profile matveb Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: ui Cc:

Description

The admin messages are being rendered after .theme-browser. They should be displayed between the themes and the header instead:

https://i.cloudup.com/X7hi0qxHeI.png

Change History (8)

#1 @matveb
11 years ago

Also, the message on THX includes the theme name when activating.

"Twenty Ten theme activated. Visit site."

#2 @SergeyBiryukov
11 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

#3 @dd32
11 years ago

In 26461:

Themes: Display Activated/Deleted messages below the H2, before the Themes. See #26305

#4 @dd32
11 years ago

In 26464:

Themes: Update the responsive layouts for the Search box after r26461. See #26305

#5 @dd32
11 years ago

Left this open for consideration of string changes to include the theme names, etc.

For Activated it's easy to include the new theme name, for Deleted, that's rather impossible.

Personally I'm inclined to leave it as-is right now, but I'll let other decide that.

#6 @dd32
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Also, the message on THX includes the theme name when activating.

Open a new ticket if anyone feels strong enough, upon reflection the rest of the admin doesn't include object names within success strings, so it feels kind of weird to me right now.

#7 @matveb
11 years ago

No strong feelings about it, seemed like a helpful tidbit at most. Maybe if you activated and went on your merry way to other tabs and then back... still, the current theme should reflect that already.

#8 @lancewillett
11 years ago

  • Component changed from Themes to Appearance
Note: See TracTickets for help on using tickets.