WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #26315


Ignore:
Timestamp:
11/29/2013 11:18:29 AM (13 years ago)
Author:
dd32
Comment:

It looks like we'll need to add a processContent-like callback to the cssjanus grunt module to alter the include, or maybe a option to cssjanus to RTL'ise all include filenames it runs into.

I'm attaching my attempt at doing this, but it's not working. I'm not sure why, but color-schemes/*/colors-rtl.min.css appears to contain too much data, but colors-rtl.css and colors.min.css are fine.

Obviously, the -rtl.min includes the .min instead of the RTL version still since I couldn't figure out a way to process the content without altering something other than the grunt file.

I don't actually know what I'm doing with Grunt here.. so feel free to ignore the patch :)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #26315 – Description

    initial v1  
    1 Currently Colour schemes don't get RTL'd versions, which results in a very bland UI when using a non-default colour scheme.
     1Currently Colour schemes don't get RTL'd versions, which results in a very bland UI when using a non-default colour scheme in an RTL environment.
    22
    3 In addition, the colour schemes include `@import url("../../colors-fresh.css");` which needs to dynamically change to `.min.css`, `-rtl.css`, and, `-rtl.min.css`.
     3In addition, the colour schemes include `@import url("../../colors-fresh.css");` which needs to dynamically change to `-rtl.css` so that minification includes the right file