#26323 closed defect (bug) (fixed)
Tab alignment incorrect on nav-menus admin page
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.8 | Priority: | normal |
| Severity: | normal | Version: | 3.8 |
| Component: | Administration | Keywords: | has-patch |
| Focuses: | ui | Cc: |
Description
On the nav menus admin page, the tabs on the add post type item section are not aligned correctly and there is a divider between the tab and tab-pane section. See screenshot.
This patch is a quick fix.
I will also attach a 2nd patch that goes further and refactors the tab CSS a little.
Currently each time tabs are used, they have their own CSS. It would be nicer if we could create a tab component that could more easily be reused. This second patch implements this for these tabs, and also the tabs for heirarchical term checkboxes on the post edit screen. It also adds slighly more padding.
Would you be interested in persuing this, or do you think the quick fix is sufficient?
Attachments (2)
Change History (5)
#1
@
11 years ago
- Component changed from General to Administration
- Keywords ui-focus has-patch added
- Milestone changed from Awaiting Review to 3.8
- Version set to trunk
#2
@
11 years ago
- Owner set to iammattthomas
- Resolution set to fixed
- Status changed from new to closed
#3
@
11 years ago
I think since we're in the beta period and coming up on code freeze, it's best to go with the simplest fix for the problem at hand, and open a new ticket for refactoring the tabs. I added in a couple of extra fixes for browser compatibility and to cover the sidebar tabs in the edit post page.
In 26539: