WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#26327 closed defect (bug) (fixed)

Available Widgets and Inactive Widgets boxes should not be collapsible

Reported by: SergeyBiryukov Owned by: iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Widgets Keywords: has-patch 2nd-opinion
Focuses: ui Cc:

Description

In 3.7, "Available Widgets" and "Inactive Widgets" were collapsible boxes, same as widget areas.

In 3.8, "Available Widgets" and "Inactive Widgets" no longer look like collapsible boxes. However, they are still collapsible, and there's an odd arrow icon on the right (see the screenshot).

I guess the boxes should not be collapsible if they are not supposed to be.

Attachments (5)

26327.png (44.2 KB) - added by SergeyBiryukov 8 years ago.
26327.diff (1.5 KB) - added by MikeHansenMe 8 years ago.
26327.2.diff (1.9 KB) - added by MikeHansenMe 8 years ago.
Includes Available Widgets
26593.3.diff (516 bytes) - added by MikeHansenMe 8 years ago.
26327.3.diff (2.5 KB) - added by nacin 8 years ago.

Download all attachments as: .zip

Change History (17)

@SergeyBiryukov
8 years ago

#1 @SergeyBiryukov
8 years ago

I guess the boxes should not be collapsible if they are not supposed to be.

Or, if they are supposed to be collabsible (e.g. for quicker access to the "Inactive Widgets" box), the UI should make that obvious.

#2 @iammattthomas
8 years ago

The only visual differences between these boxes and other collapsable boxes are:

  • font size
  • padding
  • border-bottom: 1px solid #eee.

I think the font size and padding are probably appropriate given the context; would adding back a bottom border to the sidebar name fix this?

#3 @iammattthomas
8 years ago

I need to work on my reading comprehension; I see that this refers to inactive and available widgets only. I agree that these either need standard container styling or they need to be made non-collapsable.

#4 @helen
8 years ago

I would lean non-collapsing, as I don't see a hugely compelling reason to collapse available and inactive.

@MikeHansenMe
8 years ago

#5 @MikeHansenMe
8 years ago

  • Cc mdhansen@… added

@MikeHansenMe
8 years ago

Includes Available Widgets

#6 @iammattthomas
8 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26593:

Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327, props MikeHansenMe.

#7 @nacin
8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[26593] won't work for non-English.

@MikeHansenMe
8 years ago

#8 @MikeHansenMe
8 years ago

26593.3.diff checks the sidebar id not the name.

#10 @nacin
8 years ago

Working on a patch now to allow these arrows to still exist, but appear only on hover.

In the process, I found the /* Show the arrow only on hover */ comment and I'm confused by it. It appears to be wrong.

@nacin
8 years ago

#11 @nacin
8 years ago

  • Keywords has-patch 2nd-opinion added

26327.3.diff reverts [26593] and makes it so these arrows only appear on hover (when uncollapsed). If we like the behavior, we can go with it.

#12 @iammattthomas
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26608:

Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327, props nacin.

Note: See TracTickets for help on using tickets.