Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 14 months ago

#26335 closed defect (bug) (fixed)

Twenty Fourteen: Ephemera Widget caches plugin filtering (and lack of plugin filtering) of the_content

Reported by: celloexpressions's profile celloexpressions Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Many plugins filter the_content() to add things like social sharing buttons.

The Twenty Fourteen Ephemera Widget currently ignores the potential for plugins to change the contents of the widget. For plugins that rely on external css/js files for their functionality, deactivating the plugin will remove those assets but leave the html markup displayed. This creates a bad user experience because the plugin appears to not be removed even after deleting all of its files.

Example steps to reproduce:

  1. Install & activate a plugin such as QuickShare
  2. Add the Twenty Fourteen Ephemera Widget to a sidebar
  3. Uninstall QuickShare

The html needed by QuickShare is still present in the widget. Removing and re-adding the widget fixes it.

One solution would be to prevent plugins' filters from ever applying to the widget's the_content, as they are almost never desirable for display in a widget. I'm currently hiding QuickShare from the widget with css.

Change History (4)

#1 @dimadin
11 years ago

Related (duplicate?): #26210

#2 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26577:

Twenty Fourteen: remove transient usage in Ephemera widget to fix caching issues. Props obenland, closes #26210 and #26335.

#3 @lancewillett
11 years ago

  • Milestone Awaiting Review deleted

#4 @SergeyBiryukov
11 years ago

  • Milestone set to 3.8
  • Version set to trunk
Note: See TracTickets for help on using tickets.