Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#26336 closed enhancement (fixed)

Current color scheme picker design is hard to extend

Reported by: melchoyce's profile melchoyce Owned by: azaozz's profile azaozz
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords:
Focuses: ui Cc:

Description

The color scheme picker design is nice for only a handful of schemes, but adding new themes makes it feel unwieldy and forces users to scroll.

Attachments (4)

26336.diff (4.6 KB) - added by ryelle 10 years ago.
26336.png (17.2 KB) - added by ryelle 10 years ago.
26336.2.diff (4.7 KB) - added by ryelle 10 years ago.
26336.3.diff (5.4 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (11)

#1 @melchoyce
10 years ago

  • Keywords ui-focus added

@ryelle
10 years ago

@ryelle
10 years ago

#2 @ryelle
10 years ago

26336.diff removes the dropdown styles & switches color scheme list to 26336.png. This just changes the look, functionality is all the same.

@ryelle
10 years ago

#3 @ryelle
10 years ago

26336.2.diff adds styling for responsive, dropping from 3 to 2 columns of options on <600px.

#4 @nacin
10 years ago

Do these color scheme representations make sense as tables?

#5 @azaozz
10 years ago

Not sure if the number of colors in $color_info->colors is always 4. If yes, no need for tables there. Divs or spans with inline-block and width: 25% would work just as well.

Also line 573 is not needed after the patch.

We do ksort() of the available color schemes there, not sure why. Seems the Default (a.k.a. 'fresh') should always be first.

Last edited 10 years ago by azaozz (previous) (diff)

@azaozz
10 years ago

#6 @azaozz
10 years ago

  • Milestone changed from Awaiting Review to 3.8

In 26336.3.diff:

  • Pulled the default (fresh) option to always be first.
  • Changed the structural CSS to inline-block, no float.
  • Reduced the padding a bit.

#7 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 26506:

Improve the admin color scheme picker:

  • Easier to extend.
  • Remove the "drop-down" look, show all choices inline.
  • Some PHP and JS cleanup.

Props ryelle, fixes #26336.

Note: See TracTickets for help on using tickets.