WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26338 closed enhancement (fixed)

Twenty Fourteen: Consider to re-add the Header Text Customization Option when we remove the accent color option

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In #25540, we removed the Header Text Customization Option. The biggest reason why we removed the option was because the text color option was redundant because of the accent color. Also it was tricky to remove only the text color option while keeping the hide/show header text option, and lastly the confusing, vague label "Header text".

Now, we pretty much all agree to remove the accent color option from the theme (#26220), and there is no compelling reason to not to have the option when we remove the accent color. We've heard few feedbacks/complains about the lack of the header text option from WP.com users: they need to have ability to hide their site title when they have custom header image with their identity or logo on it, and that makes sense. So I'd propose to put the header text option back.

Regarding the label, we are displaying only the site title in the preview so I think this is pretty clear what "Header Text" means in this context. In the customizer, we can rename the label to make the option more clear.

Attachments (4)

26338.diff (6.5 KB) - added by iamtakashi 4 years ago.
26338.patch (552 bytes) - added by Frank Klein 4 years ago.
26338.2.patch (2.0 KB) - added by lancewillett 4 years ago.
26338.3.patch (3.1 KB) - added by lancewillett 4 years ago.

Download all attachments as: .zip

Change History (17)

@iamtakashi
4 years ago

#1 @iamtakashi
4 years ago

  • Keywords has-patch added

#2 follow-up: @celloexpressions
4 years ago

I'm still very against this, FWIW. There is really no reason to be able to change the header text color and, like with the accent color, we're just offering an easy way to mess up your site's design by picking a bad or low-contrast color.

The accent color is only related to this in that this is a very useless color option which was given the same weight as the very useful accent and background color options in the customizer. I'd really hate to see this effectively replace the accent color option.

While there is some use for hiding the text, since these options are bound together I'd be in favor of leaving this as-is. Or, maybe we could do something like 25540.simple.diff.

One alternative option we could try: always hide the site title when the user is using a custom header?

#3 @folletto
4 years ago

I'd like to contribute by trying to clear the distinction here, with the home it might help :)

There are two different actions to be considered, that are together in the current assumptions but doesn't necessary need to be as such. The two options are:

  1. Change site title color
  2. Hide site title

With this split in consideration, my view would be that in terms of customization we have a priority list as following:

  • At the very least, the ability to hide the title, in order to work well with custom headers
  • Good to have, and could improve things a lot, a better labeling of the option
  • Nice to have, but not strictly necessary, the ability to change independently color

I would be against leaving all the options entirely out, because I've seen from some review of forums and previous clients that the "hide" option is very important. Granted, it's just a perspective, but it was very evident to me. :)

So, I would find this patch a welcome addition, or at the very least a patch to restore the option to show/hide the site title. :)

Last edited 4 years ago by folletto (previous) (diff)

#4 in reply to: ↑ 2 ; follow-up: @DrewAPicture
4 years ago

Replying to celloexpressions:

I'm still very against this, FWIW. There is really no reason to be able to change the header text color and, like with the accent color, we're just offering an easy way to mess up your site's design by picking a bad or low-contrast color.

That's kind of the point of "making it your own", isn't it? Who's to say the colors I pick are "messing up my site's design"? I say add it back in and leave it up to the theme's users to decide what colors work or don't.

#5 in reply to: ↑ 4 @celloexpressions
4 years ago

Replying to DrewAPicture:

That's kind of the point of "making it your own", isn't it? Who's to say the colors I pick are "messing up my site's design"? I say add it back in and leave it up to the theme's users to decide what colors work or don't.

That's the essence of why I now think we should keep the accent color option in its current form (please comment on #26220), since it allows you to really make your site yours. But the ability to change the color of the site title, in comparison, does very little to customize the site. I interpret "decisions, not options", in the context of theme options, as meaning that we should maximize the impact of the fewest controls possible; in this case, that would mean that we really shouldn't burden users with the site title color option since it doesn't do much and works against the design, but the accent color option works well with the design with almost any color choice, so we should highlight it and allow users to customize their site very efficiently with it.

As for being able to hide the text, I think that's a good option to provide, but it's bound to the color option in core. If there were a better way than just removing the color option from the customizer (25540.simple.diff, with a refresh) to decouple them, that would be my preference.

#6 @lancewillett
4 years ago

  • Milestone changed from Awaiting Review to 3.8

I agree we should add the option back in.

#7 @lancewillett
4 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26573:

Twenty Fourteen: re-add the Header Text Customization Option. Props iamtakashi, fixes #26338; see #25540.

#8 @Frank Klein
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Currently unchecking “Display Site Title & Tagline” works as expected in the Customizer (hides both the site title and the tagline), but after saving, the tagline still displays on the front end.

The attached patch fixes this issue, so when you uncheck “Display Site Title & Tagline” in the Customizer or uncheck "Show header text with your image." in Appearance > Header, the title and the tagline will be hidden on the front end.

@Frank Klein
4 years ago

#9 @lancewillett
4 years ago

Thanks for the patch! This fixes the front-end perfectly ... but I see a tiny problem in Customizer UI.

  1. After checking it off to hide title/description, exit Customizer, and re-open it.
  2. Now if you click it back on, the Title doesn't appear and tagline is overlayed on widget area: example: https://cloudup.com/cMNh5CSN677+
  3. Only happens if you exit the Customizer and try it after

#10 @lancewillett
4 years ago

Patch solves the Customizer refresh issue and improves logic considerably. This is my fault, the previous implementation should have taken cues from Twenty Thirteen.

Also adds ID values to style elements.

#11 @lancewillett
4 years ago

.3 patch fixes the issue of description not showing on front-end after a toggle, and better targeting of JS to refresh Customizer.

#12 @lancewillett
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26668:

Twenty Fourteen: better logic for hide/show title and description, and Customizer handling of the same. Add ID attributes to style blocks. Fixes #26338.

#13 @lancewillett
4 years ago

In 26669:

Twenty Fourteen: bump JS version for customizer.js, see #26338.

Note: See TracTickets for help on using tickets.