WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#26347 closed defect (bug) (fixed)

Themes: Actions on search results needs two clicks

Reported by: ocean90's profile ocean90 Owned by: dd32's profile dd32
Milestone: 3.8 Priority: high
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce:

  • Go to wp-admin/themes.php
  • Search for "twenty"
  • Click on the info icon
  • Nothing happens
  • Click again
  • Modal opens

Attachments (1)

26347.patch​ (481 bytes) - added by jblz 10 years ago.
Bail in themes.Collection.doSearch when the supplied search terms have already set by a prior call

Download all attachments as: .zip

Change History (5)

#1 @samuelsidler
10 years ago

  • Priority changed from normal to high

@jblz
10 years ago

Bail in themes.Collection.doSearch when the supplied search terms have already set by a prior call

#2 @jblz
10 years ago

  • Keywords has-patch added; needs-patch removed

Keystrokes in the Search view result in multiple firings of the search event handler:
source:/trunk/src/wp-admin/js/theme.js@26515#L577​

#3 @dd32
10 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26521:

Themes: Bail if the search term matches the currently rendered themes, Fixes the events being clobbered. Props jblz. Fixes #26347

#4 @lancewillett
10 years ago

  • Component changed from Themes to Appearance
Note: See TracTickets for help on using tickets.