WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #26381, comment 24


Ignore:
Timestamp:
02/26/2023 04:31:52 AM (3 years ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #26381, comment 24

    v1 v2  
    33As this is still failing silently, and we have patches and a test, the work is pretty much already done here. If this didn't have a patch, I might have agreed with closing this ticket, but I think it's worth finalizing this work with final reviews and commit.
    44
    5 While the test in [https://core.trac.wordpress.org/attachment/ticket/26381/26381.3.diff 26381.3.diff] (which is newer than the others patches and PR) needs a little work to meet standards, this whole test file needs the same improvements. IMO, the test could be committed as-is and we'll follow up to fix this whole file in one go later on.
     5While the test in [https://core.trac.wordpress.org/attachment/ticket/26381/26381.3.diff 26381.3.diff] (which is newer than the other patches and PR) needs a little work to meet standards, this whole test file needs the same improvements. IMO, the test could be committed as-is and we'll follow up to fix this whole file in one go later on.