Changes between Version 2 and Version 3 of Ticket #26381, comment 24
- Timestamp:
- 02/26/2023 04:32:21 AM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #26381, comment 24
v2 v3 3 3 As this is still failing silently, and we have patches and a test, the work is pretty much already done here. If this didn't have a patch, I might have agreed with closing this ticket, but I think it's worth finalizing this work with final reviews and commit. 4 4 5 While the test in [https://core.trac.wordpress.org/attachment/ticket/26381/26381.3.diff 26381.3.diff] (which is newer than the other patches and PR) needs a little work to meet standards, this whole test file needs the same improvements. IMO, the test could be committed as-is and we 'llfollow up to fix this whole file in one go later on.5 While the test in [https://core.trac.wordpress.org/attachment/ticket/26381/26381.3.diff 26381.3.diff] (which is newer than the other patches and PR) needs a little work to meet standards, this whole test file needs the same improvements. IMO, the test could be committed as-is and we could follow up to fix this whole file in one go later on.