Make WordPress Core

Opened 13 years ago

Closed 11 years ago

#26388 closed defect (bug) (fixed)

Add new site under multisite helper text

Reported by: Clorith Owned by: jeremyfelt
Priority: normal Milestone: 4.5
Component: Networks and Sites Version: 3.0
Severity: trivial Keywords: has-patch
Cc: Focuses: multisite

Description

When adding a new site to a multisite setup, you can define the address and the helper text states Only lowercase letters (a-z) and numbers are allowed., but you can still use dashes (no underscores though)

Rather trivial, but if people don't know they can use them one might get domain.com/myawesomesitenobodycanread as opposed to domain.com/my-awesome-site-people-can-read.

I'm not familiar with the decision around what is blocked for the address, but one view could be that not blocking dashes is an oversight as well, since underscores are blocked?

Attachments (1)

26388.diff (733 bytes ) - added by thomaswm 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
13 years ago

  • Version trunk3.7

#3 @jeremyfelt
13 years ago

  • Component MultisiteNetworks and Sites
  • Focuses multisite added

@thomaswm
11 years ago

#4 @thomaswm
11 years ago

  • Keywords has-patch added

26388.diff changes the text which is displayed on the "Add new site" page.

#5 @jeremyfelt
11 years ago

  • Milestone Awaiting Review4.5
  • Owner set to jeremyfelt
  • Status newreviewing
  • Type enhancementdefect (bug)
  • Version 3.73.0

#6 @jeremyfelt
11 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 35893:

MS: Update "Add New Site" address description text for accuracy.

Add hyphens to the list of allowed characters and add the description class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.

#7 follow-up: @SergeyBiryukov
11 years ago

  • Resolution fixed
  • Status closedreopened

Add hyphens to the list of allowed characters

Should the regex and the message in wpmu_validate_blog_signup() also be updated?

#8 in reply to: ↑ 7 @jeremyfelt
11 years ago

  • Resolutionfixed
  • Status reopenedclosed

Replying to SergeyBiryukov:

Should the regex and the message in wpmu_validate_blog_signup() also be updated?

Clearing up the inconsistencies between the add/edit/signup flows for sites should probably be covered in #20019 and #17397.

Note: See TracTickets for help on using tickets.