WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 2 months ago

Last modified 2 months ago

#26397 closed defect (bug) (fixed)

Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php

Reported by: nicolealleyinteractivecom Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: docs Cc:

Description


Attachments (4)

class-wp-posts-list-table.diff (6.9 KB) - added by nicole@… 4 months ago.
class-wp-posts-list-table.2.diff (7.3 KB) - added by nicole@… 3 months ago.
26397.3.diff (8.8 KB) - added by kpdesign 2 months ago.
Third pass
26397.diff (9.4 KB) - added by DrewAPicture 2 months ago.
Final pass

Download all attachments as: .zip

Change History (15)

comment:1 nicole@…5 months ago

  • Cc nicole@… added
  • Keywords needs-patch added

comment:2 DrewAPicture4 months ago

  • Summary changed from Hook Docs: wp-admin/includes/class-wp-posts-list-table.php to Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php

Still needing an initial patch here.

comment:3 nicole@…4 months ago

Yes, I finally have some time freeing up this week.

comment:4 nicole@…4 months ago

  • Keywords has-patch added; needs-patch removed

comment:5 jeremyfelt3 months ago

  • Component changed from Inline Docs to Post Types
  • Focuses docs added

comment:6 kpdesign3 months ago

  • Owner set to kpdesign
  • Status changed from new to assigned

comment:7 DrewAPicture3 months ago

  • Keywords needs-patch added; has-patch removed
  • Reporter changed from nicole@… to nicolealleyinteractivecom

Hi, thanks for the patch. Looks pretty good, just a couple of things:

restrict_manage_posts hook:

  • Need specificity on what kind of list table this would fire in (hint, it fires two different list tables!)

manage_taxonomies_for_$post_type_columns filter:

  • Short description needs a period, as do the parameter descriptions.

page_row_actions filter:

  • You should probably mention that the hook name changes based no whether the current post type is hierarchical (pages) or not (posts).
  • Parameter doc is missing for $post

post_date_column_time filter:

  • There's an extra space before the period in the short description.
  • The first parameter doc doesn't match, maybe a copy/pasta issue.

manage_pages_custom_column, manage_posts_custom_column, and manage_{$post->post_type}_posts_custom_column hooks:

  • You should use a docs-specific variable for the parameter lines. So instead of $post->ID, maybe just use $post_id

quick_edit_dropdown_pages_args filter:

  • Need an @see tag between the @since and first @param tags pointing to wp_dropdown_pages()

bulk_edit_custom_box/quick_edit_custom_box hooks:

  • The description should reflect that it could fire for either or of the two different hooks depending on the circumstance.
  • Use a docs-specific variable for the second parameter here. Perhaps $post_type

comment:8 nicole@…3 months ago

  • Keywords has-patch added; needs-patch removed

kpdesign2 months ago

Third pass

comment:9 kpdesign2 months ago

  • Owner changed from kpdesign to DrewAPicture

26397.3.diff contains language changes, corrected @since values, and some formatting changes.

This needs a secondary review and a recommendation.

DrewAPicture2 months ago

Final pass

comment:10 DrewAPicture2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 27255:

Inline documentation for hooks in wp-admin/includes/class-wp-posts-list-table.php.

Props nicolealleyinteractivecom, kpdesign.
Fixes #26397.

comment:11 DrewAPicture2 months ago

  • Milestone changed from Awaiting Review to 3.9
Note: See TracTickets for help on using tickets.