#26397 closed defect (bug) (fixed)
Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php
Reported by: | nicolealleyinteractivecom | Owned by: | DrewAPicture |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Attachments (4)
Change History (16)
#2
@
11 years ago
- Summary changed from Hook Docs: wp-admin/includes/class-wp-posts-list-table.php to Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php
#7
@
11 years ago
- Keywords needs-patch added; has-patch removed
- Reporter changed from nicole@… to nicolealleyinteractivecom
Hi, thanks for the patch. Looks pretty good, just a couple of things:
restrict_manage_posts
hook:
- Need specificity on what kind of list table this would fire in (hint, it fires two different list tables!)
manage_taxonomies_for_$post_type_columns
filter:
- Short description needs a period, as do the parameter descriptions.
page_row_actions
filter:
- You should probably mention that the hook name changes based no whether the current post type is hierarchical (pages) or not (posts).
- Parameter doc is missing for
$post
post_date_column_time
filter:
- There's an extra space before the period in the short description.
- The first parameter doc doesn't match, maybe a copy/pasta issue.
manage_pages_custom_column
, manage_posts_custom_column
, and manage_{$post->post_type}_posts_custom_column
hooks:
- You should use a docs-specific variable for the parameter lines. So instead of
$post->ID
, maybe just use$post_id
quick_edit_dropdown_pages_args
filter:
- Need an
@see
tag between the@since
and first@param
tags pointing towp_dropdown_pages()
bulk_edit_custom_box
/quick_edit_custom_box
hooks:
- The description should reflect that it could fire for either or of the two different hooks depending on the circumstance.
- Use a docs-specific variable for the second parameter here. Perhaps
$post_type
#9
@
11 years ago
- Owner changed from kpdesign to DrewAPicture
26397.3.diff contains language changes, corrected @since values, and some formatting changes.
This needs a secondary review and a recommendation.
Note: See
TracTickets for help on using
tickets.
Still needing an initial patch here.