WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#2640 closed defect (bug) (worksforme)

dos line endings confuse xgettext

Reported by: nbachiyski Owned by:
Milestone: Priority: low
Severity: minor Version: 2.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

xgettext: internationalized messages should not contain the `\r' escape sequence

Self-explanatory error messages. We love them, don't we? ;)

In the patch below all file ending in source files are converted to UNIX ones.

Attachments (2)

dos2unix.diff (66.0 KB) - added by nbachiyski 8 years ago.
dos2unix-updated.diff (66.0 KB) - added by nbachiyski 8 years ago.

Download all attachments as: .zip

Change History (8)

nbachiyski8 years ago

comment:1 abhay8 years ago

Could you put up another patch. I think your diff contains a bunch of extra changes that aren't what you meant.

comment:2 nbachiyski8 years ago

Here it is...

nbachiyski8 years ago

comment:3 Nazgul8 years ago

  • Keywords has-patch added
  • Milestone set to 2.1

comment:4 Nazgul7 years ago

Is this ticket still valid after the recent svn-eolstyle changes?

comment:5 matt7 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

comment:6 Nazgul7 years ago

  • Milestone 2.1 deleted
Note: See TracTickets for help on using tickets.