Opened 13 years ago
Closed 12 years ago
#26403 closed defect (bug) (fixed)
Convert path to lower case before matching for blog
| Reported by: | codix | Owned by: | nacin |
|---|---|---|---|
| Priority: | low | Milestone: | 3.9 |
| Component: | Bootstrap/Load | Version: | 3.0 |
| Severity: | minor | Keywords: | dev-feedback has-patch |
| Cc: | Focuses: | multisite |
Description
Lets take example of blog a blog example.com/mynewblog . Some users may type it example.com/MyNewBlog, others example.com/mynewblog and any variations inbetween.
There is no intensive for having mixed case blognames, it only leads to confusion among users.
Make blog path lowercase before trying to match a blog.
Patch made against trunk.
Attachments (4)
Change History (12)
#1
@
13 years ago
- Keywords dev-feedback added
- Milestone Awaiting Review → 3.9
- Priority normal → low
- Severity normal → minor
- Version 3.8 → 3.0
#2
@
13 years ago
Yes, it was an old patch we had in our system. We can drop the removal of the case insensitive flag. I'm sorry for the inconvenience.
#5
@
13 years ago
26403.3.diff is a refresh against current trunk as most previous stuff is gone.
This ensures the path is all lower case, similar to how domain is already handled.
#7
@
12 years ago
26403.3.diff still applies cleanly to trunk.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
We use
strtolower()when creating new sites and users. We also use it inget_blog_id_from_url().It seems not using
strtolower()when looking for the site *could* cause an issue if the database collation was set in a way that made the query for path case sensitive. Adding that toms-settings.phpwould likely not hurt.I don't understand the removal of the case insensitive flag in
parse_request(), that seems like an unnecessary change that could go against the goal of being case insensitive.Moving to 3.9 as it's worth discussing
strtolower( $path )as part of our site matching.