Opened 11 years ago
Closed 11 years ago
#26403 closed defect (bug) (fixed)
Convert path to lower case before matching for blog
Reported by: | codix | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.9 | Priority: | low |
Severity: | minor | Version: | 3.0 |
Component: | Bootstrap/Load | Keywords: | dev-feedback has-patch |
Focuses: | multisite | Cc: |
Description
Lets take example of blog a blog example.com/mynewblog . Some users may type it example.com/MyNewBlog, others example.com/mynewblog and any variations inbetween.
There is no intensive for having mixed case blognames, it only leads to confusion among users.
Make blog path lowercase before trying to match a blog.
Patch made against trunk.
Attachments (4)
Change History (12)
#1
@
11 years ago
- Keywords dev-feedback added
- Milestone changed from Awaiting Review to 3.9
- Priority changed from normal to low
- Severity changed from normal to minor
- Version changed from 3.8 to 3.0
#2
@
11 years ago
Yes, it was an old patch we had in our system. We can drop the removal of the case insensitive flag. I'm sorry for the inconvenience.
#5
@
11 years ago
26403.3.diff is a refresh against current trunk as most previous stuff is gone.
This ensures the path is all lower case, similar to how domain is already handled.
#7
@
11 years ago
26403.3.diff still applies cleanly to trunk.
Note: See
TracTickets for help on using
tickets.
We use
strtolower()
when creating new sites and users. We also use it inget_blog_id_from_url()
.It seems not using
strtolower()
when looking for the site *could* cause an issue if the database collation was set in a way that made the query for path case sensitive. Adding that toms-settings.php
would likely not hurt.I don't understand the removal of the case insensitive flag in
parse_request()
, that seems like an unnecessary change that could go against the goal of being case insensitive.Moving to 3.9 as it's worth discussing
strtolower( $path )
as part of our site matching.