Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#26422 closed defect (bug) (fixed)

Avoid flickering during theme searches

Reported by: nacin's profile nacin Owned by: matveb's profile matveb
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: Cc:

Description

  • Searches are so fast, that they are tough to notice, especially if you are a touch typer. If the current theme is returned, it is even worse. In 3.7, the current theme was never shown below the fold, so this wasn't a problem.
  • When a search matches an author name, we show the author in a clever overlay box. But, this is open to false positives. We should wait for the third letter to then show the author name. (We can still match the theme until then, just avoid flickering the author name.) Or we could debounce it, waiting for them to stop typing long enough before showing shorter matches. (To make Zé happy.)

Attachments (2)

theme-search-debounce.diff (570 bytes) - added by ehg 10 years ago.
debounce search on keyup and input
26422.diff (523 bytes) - added by matveb 10 years ago.

Download all attachments as: .zip

Change History (6)

@ehg
10 years ago

debounce search on keyup and input

#1 @nacin
10 years ago

  • Owner set to matveb
  • Status changed from new to reviewing

theme-search-debounce.diff seems like it could work. We should probably still wait until at least the second matched character to show authors, though.

@matveb
10 years ago

#2 @matveb
10 years ago

  • Keywords has-patch added

Debounce looks good.

#3 @nacin
10 years ago

  • Keywords has-patch removed

After some testing, let's avoid the debounce for now. There may be better way to produce feedback that a search occurred; this isn't it.

#4 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26686:

Themes: Only show author names during a search if it matches 3 or more characters.

props matveb.
fixes #26422.

Note: See TracTickets for help on using tickets.