WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26424 closed defect (bug) (fixed)

Twenty Fourteen: Apply the current menu item color to the dropdown menu arrows

Reported by: celloexpressions's profile celloexpressions Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: low
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The current menu item is green, so the corresponding dropdown arrow should change to match.

Attachments (2)

26424.diff​ (2.2 KB) - added by celloexpressions 11 years ago.
Apply the current menu item color to the dropdown indicators, where appropriate (should cover all cases for both primary and secondary nav, menus 3+ levels deep)
26424.genericons.diff​ (1.8 KB) - added by celloexpressions 11 years ago.
Display the menu drop-downs with Genericons for simplicity and so that they inherit colors

Download all attachments as: .zip

Change History (8)

@celloexpressions
11 years ago

Apply the current menu item color to the dropdown indicators, where appropriate (should cover all cases for both primary and secondary nav, menus 3+ levels deep)

#1 @celloexpressions
11 years ago

  • Keywords has-patch added

#2 @lancewillett
11 years ago

  • Milestone changed from Awaiting Review to 3.8

Nick, can you please post before and after screenshots?

#3 @lancewillett
11 years ago

After playing with the patch, I kind of don't mind the way it is with a white arrow at all times. Not sure this is worth fixing.

#4 @lancewillett
11 years ago

  • Priority changed from normal to low

@celloexpressions
11 years ago

Display the menu drop-downs with Genericons for simplicity and so that they inherit colors

#5 @lancewillett
11 years ago

Genericons patch looks good, testing in Chrome, Safari, Firefox on Mac and IE9, IE10, and "Edge" on Windows 7.

#6 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26662:

Twenty Fourteen: rework "current menu" submenu icons to use Genericons for simplicity and to inherit colors better. Props celloexpressions, fixes #26424.

Note: See TracTickets for help on using tickets.