Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26432 closed defect (bug) (fixed)

"My Account" icon disappears from Toolbar on smaller screens for lower roles

Reported by: alphagolf_fr's profile AlphaGolf_fr Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: dev-feedback
Focuses: Cc:

Description

Couldn't find any related ticket on this. Ths Toolbar icon "My Account" (and the user menu underneath) disappears from screen (tablet mode), for roles under Author (cap "edit_posts").

On smaller screens (less than 782px width), for roles that have the capability to do so, the icons for "Comments" and "Add New" are moved to the right corner of the screen, inline with an appropriate margin. "My Account" is then added at its proper place, relatively to these ones. On roles that never see these icons, "My Account" gets a margin-right of 150px that pushes it outside the screen...

I was expecting to have "My Account" for all roles of the site or network of site, at all screen resolutions.

Attachments (3)

26432-myaccount-with.jpg (30.8 KB) - added by AlphaGolf_fr 11 years ago.
width slightly above 782px, normal display, as expected
26432-myaccount-without.jpg (51.3 KB) - added by AlphaGolf_fr 11 years ago.
width under 782px, Firebug pointing to the li
26432-myaccount-manually-shifted.jpg (52.2 KB) - added by AlphaGolf_fr 11 years ago.
Firebug pointing to the li "wp-admin-bar-my-account" and margin-right inhibited: avatar comes back to where I was expecting it

Download all attachments as: .zip

Change History (9)

#1 @nacin
11 years ago

Could you screenshot this for us?

#2 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8

Moving to 3.8 for investigation.

@AlphaGolf_fr
11 years ago

width slightly above 782px, normal display, as expected

@AlphaGolf_fr
11 years ago

width under 782px, Firebug pointing to the li

@AlphaGolf_fr
11 years ago

Firebug pointing to the li "wp-admin-bar-my-account" and margin-right inhibited: avatar comes back to where I was expecting it

#3 @AlphaGolf_fr
11 years ago

This is a typical test install with default settings, updated to trunk using WordPress Beta Tester. Lang is set to 'fr_FR'. That user role is Subscriber.

#4 @nacin
11 years ago

  • Keywords dev-feedback added
  • Owner set to iammattthomas
  • Status changed from new to assigned

MT is currently investigating.

#5 @iammattthomas
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 26710:

At responsive sizes, remove the hard-coded fixed positioning for Comments and Add New in the toolbar. Make links slightly wider to better fill small-screen devices. Fixes #26432.

#6 @iammattthomas
11 years ago

We were previously using some gnarly negative margin tricks to slide Comments and Add New to the right. My thinking is that the simplest solution is usually the best -- since the fixed positioning causes problems if the Comments and Add New icons aren't there (as in the case of a Subscriber), let's just let the links remain in their default position, and space them out a little better at responsive sizes.

Before: https://cloudup.com/csZBR4vPCmx
After: https://cloudup.com/coMrj01nu4f

Last edited 11 years ago by iammattthomas (previous) (diff)
Note: See TracTickets for help on using tickets.