WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26434 closed defect (bug) (fixed)

Themes: when initiating a search, avoid triggering a reset event when it's not necessary

Reported by: matveb's profile matveb Owned by: nacin's profile nacin
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: Cc:

Description

The first time the collection is reset we are triggering a re-rendering of the view (with exactly the same data) that is not needed at that point, as we are only preparing the data for searching. Passing silent: true should be marginally more performant.

Attachments (1)

26434.diff​ (1.0 KB) - added by matveb 11 years ago.

Download all attachments as: .zip

Change History (4)

@matveb
11 years ago

#1 @matveb
11 years ago

Patch above also removes a self = this assignment that can be cleaned up for this context.

#2 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26685:

Themes: when initiating a search, avoid triggering a reset event when it's not necessary.

props matveb.
fixes #26434.

Note: See TracTickets for help on using tickets.