Context Navigation

← Previous Ticket
Next Ticket →

#26439 closed defect (bug) (fixed)

Arrows for revisions slider handle in two handled mode need attention

Reported by:	adamsilverstein	Owned by:	iammattthomas
Priority:	low	Milestone:	3.8
Component:	Revisions	Version:	3.8
Severity:	minor	Keywords:
Cc:		Focuses:

Description

When viewing the revisions screen in 'compare two revisions' mode, the new graphics for the right hand slider handle introduced by 3.8/mp6 are slightly off (they are also slightly different in firefox vs chrome):

by comparison, the handles in 3.6 looked like this:

a small tweak to the css for the right handle gets us this, which is better (patch attached)

Another more serious regression is the handles in RTL mode - the placement is off (should be over tick mark) and the arrow directions are reversed - whoops! Fixing this one next:

Attachments (2)

26439.diff (350 bytes ) - added by adamsilverstein 13 years ago.: correct arrow placement for two handles mode to handle
26439.2.diff (904 bytes ) - added by adamsilverstein 13 years ago.: correct placement & direction of slider handles in rtl mode

Download all attachments as: .zip

Change History (9)

@adamsilverstein
13 years ago

Attachment 26439.diff added

correct arrow placement for two handles mode to handle

#1 @matt
13 years ago

Milestone Awaiting Review → 3.8
Priority normal → low
Severity normal → minor

#2 @iammattthomas
13 years ago

Owner set to iammattthomas
Status new → assigned

#3 @iammattthomas
13 years ago

In 26709:

Fix the positioning of arrow icons in the slider buttons in Revisions. See #26439.

#4 @iammattthomas
13 years ago

I went about this a slightly different way because there was some crufty/unnecessary CSS on those icons. Fixing the RTL issue is still outstanding.

@adamsilverstein
13 years ago

Attachment 26439.2.diff added

correct placement & direction of slider handles in rtl mode

#5 @adamsilverstein
13 years ago

26439.2.diff: correct placement & direction of slider handles in rtl mode:

#6 @iammattthomas
13 years ago

Resolution → fixed
Status assigned → closed

In 26717:

Correct the direction of arrow icons when comparing revisions in RTL. Fixes #26439, props adamsilverstein.

#7 @iammattthomas
13 years ago

r26717 fixes the display bug for RTL, but it's working around the incorrectly generated RTL css. Barring a solution for that before freeze though, this fixes the immediate problem.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#26439 closed defect (bug) (fixed)

Arrows for revisions slider handle in two handled mode need attention

Description

Attachments (2)

Change History (9)

@adamsilverstein 13 years ago

#1 @matt 13 years ago

#2 @iammattthomas 13 years ago

#3 @iammattthomas 13 years ago

#4 @iammattthomas 13 years ago

@adamsilverstein 13 years ago

#5 @adamsilverstein 13 years ago

#6 @iammattthomas 13 years ago

#7 @iammattthomas 13 years ago

Download in other formats:

@adamsilverstein
13 years ago

#1 @matt
13 years ago

#2 @iammattthomas
13 years ago

#3 @iammattthomas
13 years ago

#4 @iammattthomas
13 years ago

@adamsilverstein
13 years ago

#5 @adamsilverstein
13 years ago

#6 @iammattthomas
13 years ago

#7 @iammattthomas
13 years ago