WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#26442 closed defect (bug) (fixed)

ThickBox z-index conflicts with admin menu and bar

Reported by: shaunandrews Owned by: nacin
Milestone: 3.8 Priority: high
Severity: major Version: 3.8
Component: General Keywords: has-patch
Focuses: Cc:
PR Number:

Description

The Thickbox modal, which is used (at least) to display theme update details is overlapped by the wp-admin menu and bar:

https://i.cloudup.com/rE77v4yXfb.png

Attachments (2)

26442.diff (549 bytes) - added by shaunandrews 6 years ago.
26442.2.diff (1.5 KB) - added by ryelle 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.8

#2 @nacin
6 years ago

  • Priority changed from normal to high
  • Severity changed from normal to major

We should probably try to restore the admin menu to whatever z-index it was in 3.7. I'm guessing it changed.? Curious, though, how this didn't affect the customizer or media modal.

@shaunandrews
6 years ago

#4 @shaunandrews
6 years ago

26442.diff fixes this by dropping the z-index of the sticky-menu from 9999 to 99, which lets the Thickbox (and its z-index: 100;) remain overtop.

#5 @shaunandrews
6 years ago

  • Keywords has-patch added

@ryelle
6 years ago

#6 @ryelle
6 years ago

26442.2.diff also addresses the z-index issue in this video: https://cloudup.com/cpwFnV0zFIo, where the thickbox loaded behind the theme modal on smaller screens. I've adjusted the z-indices of the theme modal & thickbox: the theme modal's z-index is now slightly more sane, and thickbox has been increased.

#7 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26701:

Fix z-indexes as it relates to thickbox, the theme modal, and admin menu.

props ryelle, shaunandrews.
fixes #26442.

#8 @nacin
6 years ago

In 27833:

Restore the original z-index of the sticky admin menu, as first set in [26442].

The inline comment is now correct again. This z-index was changed in [26701], but those circumstances no longer apply after [27532].

props mordauk.
see #26442, #26952.
fixes #26567.

Note: See TracTickets for help on using tickets.