WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#26453 closed defect (bug) (fixed)

Twenty Fourteen: html element has a 'no-js' class

Reported by: johnbillion Owned by: nacin
Priority: normal Milestone: 3.8
Component: Bundled Theme Version: 3.8
Severity: minor Keywords: has-patch
Cc: Focuses:

Description

The html element in Twenty Fourteen has a no-js class but there's no JavaScript in place to change it to js. The class isn't used anywhere but we may as well replicate the functionality that we use in the admin area.

Attachments (2)

26435.diff​ (394 bytes ) - added by johnbillion 13 years ago.
26453.diff​ (784 bytes ) - added by johnbillion 13 years ago.

Download all attachments as: .zip

Change History (7)

@johnbillion
13 years ago

#1 @johnbillion
13 years ago

  • Keywords has-patch added; needs-patch removed

Patch

#2 @nacin
13 years ago

If we don't use it anywhere, it'd be better to just strip out a little excess code.

@johnbillion
13 years ago

#3 @johnbillion
13 years ago

26453.diff​ just removes the unused class.

#4 @nacin
13 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 26729:

Twenty Fourteen: Remove unused and untoggled no-js class.

props johnbillion.
fixes #26453.

#5 @lancewillett
13 years ago

  • Component Themes → Bundled Theme
Note: See TracTickets for help on using tickets.