WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26453 closed defect (bug) (fixed)

Twenty Fourteen: html element has a 'no-js' class

Reported by: johnbillion Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: minor Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The html element in Twenty Fourteen has a no-js class but there's no JavaScript in place to change it to js. The class isn't used anywhere but we may as well replicate the functionality that we use in the admin area.

Attachments (2)

26435.diff (394 bytes) - added by johnbillion 7 years ago.
26453.diff (784 bytes) - added by johnbillion 7 years ago.

Download all attachments as: .zip

Change History (7)

@johnbillion
7 years ago

#1 @johnbillion
7 years ago

  • Keywords has-patch added; needs-patch removed

Patch

#2 @nacin
7 years ago

If we don't use it anywhere, it'd be better to just strip out a little excess code.

@johnbillion
7 years ago

#3 @johnbillion
7 years ago

26453.diff just removes the unused class.

#4 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26729:

Twenty Fourteen: Remove unused and untoggled no-js class.

props johnbillion.
fixes #26453.

#5 @lancewillett
7 years ago

  • Component changed from Themes to Bundled Theme
Note: See TracTickets for help on using tickets.