WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26459 closed defect (bug) (fixed)

Themes: if a theme has a 300px width screenshot, don't try to increase its size

Reported by: matveb's profile matveb Owned by: nacin's profile nacin
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: Cc:

Description

If a theme is using an old 300px width version of a screenshot let's not stretch it on the detailed view as we have virtually no information and it will just look bad. This would also be an incentive for themes to update their screenshots.

Attachments (3)

26459.diff​ (1.9 KB) - added by matveb 11 years ago.
26459.1.diff​ (1.9 KB) - added by matveb 11 years ago.
26459.2.diff​ (1.8 KB) - added by matveb 11 years ago.

Download all attachments as: .zip

Change History (7)

@matveb
11 years ago

@matveb
11 years ago

@matveb
11 years ago

#1 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26738:

Themes: If a theme only has a very-old-school 300px-wide screenshot (or narrower), don't stretch it.

props matveb.
fixes #26459.

#2 @nacin
11 years ago

In 26740:

Revert Twenty Ten's original screenshot. Was using Kubrick to test [26738]. I hope this gave lancewillett a laugh. see #26459.

#3 @nacin
11 years ago

In 26765:

Themes: Ensure the image returns a width before checking that it is less than 300px.

see #26459.

#4 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8

I was able to trigger image.width returning 0 for some reason. Sporadically. Couldn't track it down; [26765] papers over it for now.

Note: See TracTickets for help on using tickets.