WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26461 closed defect (bug) (fixed)

RTL: Image thumbnails partially hidden from view in Media window.

Reported by: siobhyb Owned by: ocean90
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: RTL Keywords:
Focuses: Cc:

Description (last modified by ocean90)

Steps to reproduce:

  1. Open WordPress site in an RTL language.
  2. Ensure some images are uploaded to the Media library.
  3. Go to edit a new page, and select the "Set Featured Image" button.

Result:

In the resulting window, the thumbnails are partially obscured and there is a blank space to their right (highlighted in below screenshot.)

See attached Screenshot.

First pass at patch for this is attached.

Attachments (3)

rtl-bug.png (93.3 KB) - added by siobhyb 6 years ago.
RTL bug.
#26461.patch (354 bytes) - added by siobhyb 6 years ago.
First pass at RTL fix.
26461.patch (424 bytes) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (8)

@siobhyb
6 years ago

RTL bug.

@siobhyb
6 years ago

First pass at RTL fix.

#1 @siobhyb
6 years ago

  • Cc siobhanbamber@… added

#2 @siobhyb
6 years ago

Eek.. Didn't realise how big that image was and can't seem to edit ticket. Sorry.

#3 follow-up: @ocean90
6 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 3.8

Confirmed.

siobhyb, through the new build process the RTL styles are handled by CSSJanus.

@ocean90
6 years ago

#4 in reply to: ↑ 3 @nacin
6 years ago

Replying to ocean90:

Confirmed.

siobhyb, through the new build process the RTL styles are handled by CSSJanus.

But, it's no problem if you patch core.svn.wordpress.org for RTL fixes; we'll make the transition. We'd rather have a patch pointing me to the proper rules than nothing at all.

#5 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 26748:

RTL: Don't flip thumbnail positions in Insert Media window.
Restores pre-3.8 behavior.

props siobhyb for the initial patch.
fixes #26461.

Note: See TracTickets for help on using tickets.