Twenty Fourteen: Errant \ in page.php

[Ipstenu]

From the forums: ​http://wordpress.org/support/topic/warning-unexpected-character-in-input-ascii92-state1

Warning: Unexpected character in input: '\' (ASCII=92) state=1

There is clearly a backslash ("\") just before the colon of the if statement on line 19.

And lo there is: ​http://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyfourteen/page.php#L19

Patch attached.

[Ipstenu]

Removing stray /

[nacin]

In 26757:

Twenty Fourteen: Remove stray slash.

props Ipstenu.
fixes #26467.

[Ipstenu]

Using brackets instead

[Ipstenu]

Actually looking at this more, it looks like the last revision reverted the change to brackets.

I attached a second diff with Drew's inline remarks and keeping brackets :(

[Ipstenu]

Reopening since the other diff may need to be used instead with brackets (per Ocean90). Sorry, missed this the first time, and only notice when I stepped back to see when this broke.

[lancewillett]

I'd prefer not to change to braces, here. Thanks for the errant / catch, though!

[obenland]

Yes, I think we agreed with sticking to the more verbose syntax in templates.

[ocean90]

​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-12-07&sort=asc#m747777

[nacin]

Generally speaking, we use braces whenever we remain entirely within PHP, and alternative style when we're breaking in and out of PHP. It seems in this case moving to braces makes sense. In themes, it is additionally always used for the loop, and the while is usually on the same line as the_post(). For two-line if statements, there's basically no reason to use alternative style.

There's not a lot of consistency when looking through the default themes, in terms of alternative style in templates. In Twenty Fourteen, about a third of if statements in templates use braces, a third use alternative syntax then immediately break out of PHP (proper), and another third use alternative syntax then stay in PHP (ideally not used).

[lancewillett]

In 26761:

Twenty Fourteen: clean up PHP braces style in page templates. Closes #26467.