WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 3 months ago

#26469 new enhancement

Twenty Fourteen: Better Audio/Video Player Styling with Genericons

Reported by: celloexpressions Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I just realized that we can easily replace the default icons in the Audio/Video players with Genericons, and also introduce some color.

While this is fine to wait until .1, it would introduce some color rules that child themers would probably want to override.

Attachments (2)

26469.diff (1.8 KB) - added by celloexpressions 4 months ago.
First pass at improved Media Element styling with Genericons instead of the default non-flat icons.
twentyfourteen-mediaelements-genericons.png (240.8 KB) - added by celloexpressions 4 months ago.
Some screenshots, although the best way to see the interactions is to test the patch.

Download all attachments as: .zip

Change History (6)

celloexpressions4 months ago

First pass at improved Media Element styling with Genericons instead of the default non-flat icons.

comment:1 celloexpressions4 months ago

  • Keywords has-patch added

celloexpressions4 months ago

Some screenshots, although the best way to see the interactions is to test the patch.

comment:2 lancewillett4 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Version set to trunk

I think we can look for 1.1, or you can merge into your colors plugin so people can use it right away.

comment:3 celloexpressions4 months ago

Added to Fourteen Colors as a component for now, and we can look at it for 1.1 unless it gets horrible feedback. We'd also want tweaks from iamtakashi.

comment:4 celloexpressions3 months ago

Genericons 3.0.3 introduced a new "fullscreen" icon, so we could consider using that instead of genericon-external for the fullscreen icon (unless we don't update them for some reason). Might want to ask for some sort of a "collapse" or "escape" icon to go with that, although the X works fine too.

By the way, this has been in Fourteen Colors for the past 6 weeks and I haven't heard any feedback either way, which I think is a good sign. At a minimum it flattens the design a bit more to bring it more closely in link with the rest of Twenty Fourteen, and it also makes it even easier for child themers to customize the audio/video players.

Note: See TracTickets for help on using tickets.