Bulk Actions Not Working for Some Plugins

[miqrogroove]

Steps to reproduce:

1. Go to Installed Plugins.
2. Deactivate all plugins.
3. Use the select-all box (either one).
4. Un-select the last plugin at the bottom of the list.
5. Use the Bulk Actions drop down (either one).
6. Select Activate.
7. Click the Apply button.

Expected result:

• All but the last plugin should activate.

Actual result:

• The first plugin does not activate, in addition to the last plugin.

Tried:

• Different browsers, still broken.
• WordPress 3.7, works correctly.

[SergeyBiryukov]

Could not reproduce in Firefox 25, Chrome 31, or Opera 12. Works as expected for me.

[ocean90]

I can't reproduce either.

[miqrogroove]

Okay, more detail:

The plugin at the top of my Plugins list is Disable WordPress Core Updates v1.5 from ​http://wordpress.org/plugins/disable-wordpress-core-update/

My WordPress 3.7 test site still had v1.4 of the plugin. When I updated the plugin to v1.5, I was able to reproduce the silent failure for bulk activation. The single Activate link still works in all versions.

[kpdesign]

I can reproduce this in Chrome 31 and Firefox 25 (Windows 7), but it's the 2nd plugin from the top that doesn't activate (​Background Updates Tester). First plugin is Akismet.

[miqrogroove]

Replying to kpdesign:

I can reproduce this in Chrome 31 and Firefox 25 (Windows 7), but it's the 2nd plugin from the top that doesn't activate (​Background Updates Tester). First plugin is Akismet.

I installed that and see the same thing. Both the Disable Updates and the Background Updates plugins stay deactivated during bulk activations.

[dd32]

This is caused by a Multisite-specific usecase applying to non-multisite.

At present the Bulk plugin activation process only activates plugins which are:

1. Not activated already
2. Not a Network-wide-only plugin

What it should actually do:

1. Not activated already
2. If Multisite, Not a Network-wide-only plugin (The code branch affected only runs in non-network-admin)

Single plugin activation follows a similar branch to the expected:

1. If activated, stop
2. If Multisite, and we're not in the network admin, and it's a network-wide-only plugin, stop.

Patch attached.

Introduced with #21187 [21740]

[miqrogroove]

Patch tested. Fixed. I'd tag this 3.9 early so it doesn't lose traction.

[miqrogroove]

dd32, you can commit 26487.diff now?

[johnbillion]

In 27413:

Fix bulk activation of network-only plugins. Fixes #26487. Props dd32.