Make WordPress Core

Opened 2 years ago

Closed 3 months ago

#26494 closed defect (bug) (fixed)

Plugins page errors should use 'error' class rather than 'updated'

Reported by: dd32 Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.8
Component: Plugins Keywords: has-patch commit
Focuses: administration Cc:


Just noticed that some errors on the plugins page are using the Informational notification colours instead of an error colour.

It makes sense that we should update these.

Attachments (3)

26494.diff (815 bytes) - added by dd32 2 years ago.
26494.2.diff (1.9 KB) - added by dd32 2 years ago.
spotted another two cases
26494.3.diff (721 bytes) - added by swissspidy 3 months ago.

Download all attachments as: .zip

Change History (9)

2 years ago

#1 @dd32
2 years ago

  • Keywords has-patch commit added

2 years ago

spotted another two cases

#2 @nacin
2 years ago

"No out of date plugins were selected." might as well say "All selected plugins are up to date." As in, you wanted to update plugins X, Y, and Z, and they are indeed updated. Arguably not a failure condition; it can go either way.

#3 @dd32
2 years ago

I agree, that particular message is worded as an error at present, but could be re-worded to be more friendly "yay, they're all up to date already" instead.

#4 @nacin
22 months ago

  • Component changed from Administration to Plugins
  • Focuses administration added

3 months ago

#5 @swissspidy
3 months ago

  • Milestone changed from Awaiting Review to 4.4

The first two cases have already been fixed in #28260.

26494.3.diff changes the wording of No out of date plugins were selected. to All selected plugins are up to date., keeping the notice class as it isn't really an error.

#6 @wonderboymusic
3 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 33983:

Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition.

Props swissspidy.
Fixes #26494.

Note: See TracTickets for help on using tickets.