Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#26496 closed defect (bug) (fixed)

Themes: "Search" is ambiguous and confusing

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 3.8 Priority: high
Severity: major Version: 3.8
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Here's what you see on the themes page:

Themes (#) [Add New] [Search...]

If you swapped the search input for Add New, you'd think it was a search input for new themes. I think that it's highly likely that even in their current position, that is exactly what a lot of people may do.

We've had this confusion with both plugin and theme search fields (hell, I've done it myself), which is why the labels for the search submit buttons are "Search Installed Themes" and "Search Installed Plugins".

The search is also missing a label (even just screen-reader-text). We had this in 3.7:

<label class="screen-reader-text" for="theme-search-input"><?php _e('Search Installed Themes'); ?>:</label>

Suggestions:

  • Add missing label, as above
  • Change placeholder to be "Search installed themes..."
  • Try to float the search input to the right, as it is on every other screen in the admin

Attachments (4)

26496.patch (1.5 KB) - added by SergeyBiryukov 11 years ago.
26496.after.png (654.9 KB) - added by SergeyBiryukov 11 years ago.
26496.diff (1.4 KB) - added by nacin 11 years ago.
26496.2.diff (1.4 KB) - added by nacin 11 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
11 years ago

  • Keywords has-patch added

@nacin
11 years ago

@nacin
11 years ago

#2 @nacin
11 years ago

  • Keywords commit added

26496.2.diff shares the existing string. The 3.7 label had the colon outside the translation.

#3 @nacin
11 years ago

Some chatter here: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-12-09&sort=asc#m749264. Floating it right would be nice but it messes with the design too much. The label and placeholder are fine. We also don't have a live-search on any other screen (closest to it is internal linking) so the UX is different anyway.

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26827:

Themes: use explicit 'search installed themes' label and placeholder.

fixes #26496.

#5 @matveb
11 years ago

What about "Search your themes" instead?

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 years ago

Note: See TracTickets for help on using tickets.