WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 15 months ago

Last modified 7 months ago

#26518 closed defect (bug) (fixed)

Added a flipped update icon to dashicons and assigned it to updates, made the edit post icon a bit smaller

Reported by: empireoflight Owned by: nacin
Milestone: 3.8.1 Priority: low
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit fixed-major
Focuses: ui Cc:

Description


Attachments (6)

big_patch.diff (155.6 KB) - added by empireoflight 16 months ago.
patch
fonts.zip (74.9 KB) - added by empireoflight 16 months ago.
Font files
26518.diff (57.3 KB) - added by melchoyce 16 months ago.
fonts.2.zip (75.0 KB) - added by melchoyce 16 months ago.
26518.2.diff (61.0 KB) - added by melchoyce 16 months ago.
fonts.3.zip (75.0 KB) - added by melchoyce 16 months ago.

Download all attachments as: .zip

Change History (26)

@empireoflight16 months ago

patch

@empireoflight16 months ago

Font files

comment:1 @SergeyBiryukov16 months ago

  • Component changed from General to Administration
  • Keywords ui-focus has-patch added

comment:2 follow-up: @dd3216 months ago

Looking at the diff:

  • Please don't include .min.css's in patches, makes them hard to read and they're automatically generated
  • Glyph 113 - Existing Backwards update icon left as-is, still displayed on Themes and Plugins pages
  • Glyph 327 - Existing Edit icon for Admin Bar (font-size increased)
  • Glyph 463 - New Correct facing Update icon added and used for Admin Bar
  • Glyph 464 - New Edit Icon added and assigned to .dashicons-edit which isn't used within core
  • Strangeness with Glyph e000 renaming to 25fc (Not sure what that entry is in the SVG, or why it's changed)

comment:3 in reply to: ↑ 2 ; follow-up: @empireoflight16 months ago

OK, do I need to do anything else or is this taken care of? Sorry, I don't usually submit code patches. How do you test locally without editing the min files?

Replying to dd32:

Looking at the diff:

  • Please don't include .min.css's in patches, makes them hard to read and they're automatically generated
  • Glyph 113 - Existing Backwards update icon left as-is, still displayed on Themes and Plugins pages
  • Glyph 327 - Existing Edit icon for Admin Bar (font-size increased)
  • Glyph 463 - New Correct facing Update icon added and used for Admin Bar
  • Glyph 464 - New Edit Icon added and assigned to .dashicons-edit which isn't used within core
  • Strangeness with Glyph e000 renaming to 25fc (Not sure what that entry is in the SVG, or why it's changed)

comment:4 in reply to: ↑ 3 @SergeyBiryukov16 months ago

Replying to empireoflight:

How do you test locally without editing the min files?

There's a constant you can add to your wp-config.php file to use unminified files:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

comment:5 @dd3216 months ago

  • Milestone changed from Awaiting Review to 3.8

Shifting to 3.8 for review purposes, may or may not be bumped to 3.9.

As for if there's anything else to do.. Questions are:

  1. Why do we have two edit icons now? Is it really needed? and if so, where should the new one be used? (since it doesn't appear to be being used currently)
  2. Should Glyph 463 (updates icon, clockwise rotation) just replace 113 (updates, anti-clockwise rotation) instead of being in addition to it? If not, the other uses of the icon also need updating

Don't necessarily need a new patch, someone else can take it and run with it to finish up any CSS alterations.

comment:6 @nacin16 months ago

  • Priority changed from normal to low

I'm with dd32: Existing glyphs can be updated with the changes in these cases, unless I am missing something.

comment:7 @nacin16 months ago

  • Milestone changed from 3.8 to Future Release

@melchoyce16 months ago

@melchoyce16 months ago

comment:8 @melchoyce16 months ago

26518.diff replaces the counter-clockwise update icon with the clockwise update icon, as well as replacing the larger edit icon with the smaller edit icon. I've also included the update font files: fonts.2.zip.

There are two additional icons to add: .dashicons-email and .dashicons-email-alt. Should I create a new ticket for them?

comment:9 @nacin16 months ago

  • Milestone changed from Future Release to 3.8.1

comment:10 @ircbot16 months ago

This ticket was mentioned in IRC in #wordpress-dev by melchoyce. View the logs.

@melchoyce16 months ago

@melchoyce16 months ago

comment:11 @melchoyce16 months ago

26518.2.diff adds the following icons:

  • Email
  • Email-alt
  • SOS
  • Clock
  • Desktop
  • Tablet
  • Smartphone
  • Testimonial

Additionally, it bumps up the .dashicons class to 20px, to fit with the font's base grid. Updated fonts are also attached.

comment:12 @nacin15 months ago

  • Keywords commit added

comment:13 @ircbot15 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

comment:14 @ocean9015 months ago

In 26925:

Dashicons: Update to the latest dashicons files.

props empireoflight, melchoyce.
see #26518 for trunk.

comment:15 @ocean9015 months ago

  • Keywords fixed-major added

comment:16 @nacin15 months ago

[26925] changed .dashicons from 16px to 20px, which screwed up some of the new Trac stuff which wanted them at 16px. I'm adjusting Trac; just curious if there is a concern that change could break things.

comment:17 @ircbot15 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

comment:18 @nacin15 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26965:

Dashicons: Update to the latest dashicons files.

Merges [26925] to the 3.8 branch.

props empireoflight, melchoyce.
fixes #26518.

comment:19 @nacin15 months ago

  • Type changed from enhancement to defect (bug)

comment:20 @ircbot7 months ago

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

Note: See TracTickets for help on using tickets.