#26518 closed defect (bug) (fixed)
Added a flipped update icon to dashicons and assigned it to updates, made the edit post icon a bit smaller
Reported by: | empireoflight | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.8.1 | Priority: | low |
Severity: | normal | Version: | 3.8 |
Component: | Administration | Keywords: | has-patch commit fixed-major |
Focuses: | ui | Cc: |
Description
Attachments (6)
Change History (26)
#1
@
11 years ago
- Component changed from General to Administration
- Keywords ui-focus has-patch added
#2
follow-up:
↓ 3
@
11 years ago
Looking at the diff:
- Please don't include .min.css's in patches, makes them hard to read and they're automatically generated
- Glyph 113 - Existing Backwards update icon left as-is, still displayed on Themes and Plugins pages
- Glyph 327 - Existing Edit icon for Admin Bar (font-size increased)
- Glyph 463 - New Correct facing Update icon added and used for Admin Bar
- Glyph 464 - New Edit Icon added and assigned to .dashicons-edit which isn't used within core
- Strangeness with Glyph e000 renaming to 25fc (Not sure what that entry is in the SVG, or why it's changed)
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
11 years ago
OK, do I need to do anything else or is this taken care of? Sorry, I don't usually submit code patches. How do you test locally without editing the min files?
Replying to dd32:
Looking at the diff:
- Please don't include .min.css's in patches, makes them hard to read and they're automatically generated
- Glyph 113 - Existing Backwards update icon left as-is, still displayed on Themes and Plugins pages
- Glyph 327 - Existing Edit icon for Admin Bar (font-size increased)
- Glyph 463 - New Correct facing Update icon added and used for Admin Bar
- Glyph 464 - New Edit Icon added and assigned to .dashicons-edit which isn't used within core
- Strangeness with Glyph e000 renaming to 25fc (Not sure what that entry is in the SVG, or why it's changed)
#4
in reply to:
↑ 3
@
11 years ago
Replying to empireoflight:
How do you test locally without editing the min files?
There's a constant you can add to your wp-config.php
file to use unminified files:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG
#5
@
11 years ago
- Milestone changed from Awaiting Review to 3.8
Shifting to 3.8 for review purposes, may or may not be bumped to 3.9.
As for if there's anything else to do.. Questions are:
- Why do we have two edit icons now? Is it really needed? and if so, where should the new one be used? (since it doesn't appear to be being used currently)
- Should Glyph 463 (updates icon, clockwise rotation) just replace 113 (updates, anti-clockwise rotation) instead of being in addition to it? If not, the other uses of the icon also need updating
Don't necessarily need a new patch, someone else can take it and run with it to finish up any CSS alterations.
#6
@
11 years ago
- Priority changed from normal to low
I'm with dd32: Existing glyphs can be updated with the changes in these cases, unless I am missing something.
#8
@
11 years ago
26518.diff replaces the counter-clockwise update icon with the clockwise update icon, as well as replacing the larger edit icon with the smaller edit icon. I've also included the update font files: fonts.2.zip.
There are two additional icons to add: .dashicons-email and .dashicons-email-alt. Should I create a new ticket for them?
This ticket was mentioned in IRC in #wordpress-dev by melchoyce. View the logs.
11 years ago
#11
@
11 years ago
26518.2.diff adds the following icons:
- Email-alt
- SOS
- Clock
- Desktop
- Tablet
- Smartphone
- Testimonial
Additionally, it bumps up the .dashicons class to 20px, to fit with the font's base grid. Updated fonts are also attached.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
11 years ago
#16
@
11 years ago
[26925] changed .dashicons from 16px to 20px, which screwed up some of the new Trac stuff which wanted them at 16px. I'm adjusting Trac; just curious if there is a concern that change could break things.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
11 years ago
#18
@
11 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 26965:
patch