WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 weeks ago

#26520 closed defect (bug) (fixed)

WordPress News Dashboard Widget Videos shows empty box on hover

Reported by: NikV Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 2.7
Component: Widgets Keywords: has-patch 3.9-early
Focuses: Cc:

Description

For the WordPress News Widget, the regular articles come with a preview text box on hover, but for videos, that box shows up empty. This may be really trivial, but just something to look at for a future release.

Image: https://i.cloudup.com/w4hsYa5OuD.jpg

I am on Chrome running WordPress 3.8 RC2.

Attachments (2)

26520.patch (788 bytes) - added by SergeyBiryukov 4 months ago.
26520.2.patch (1.9 KB) - added by SergeyBiryukov 7 weeks ago.

Download all attachments as: .zip

Change History (10)

comment:1 NikV4 months ago

  • Summary changed from WordPress News Dashboard Widget shows empty box on hover to WordPress News Dashboard Widget Videos shows empty box on hover

SergeyBiryukov4 months ago

comment:2 SergeyBiryukov4 months ago

  • Component changed from General to Widgets
  • Keywords has-patch 3.9-early added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from trunk to 2.7

Introduced in [9219].

Video links have a space as the title attribute: title=" ", and Chrome displays it.

Adding trim() to wp_widget_rss_output() fixes that.

comment:3 follow-up: helen4 months ago

Ugh. I thought we were going to remove the title attribute completely here, because:

http://f.cl.ly/items/3Z0S0j302u2A0U2L1T1k/Screen%20Shot%202013-11-15%20at%204.38.18%20PM.png

comment:4 in reply to: ↑ 3 SergeyBiryukov4 months ago

Replying to helen:

I thought we were going to remove the title attribute completely here

Related: #26552

comment:5 SergeyBiryukov7 weeks ago

#27241 was marked as a duplicate.

SergeyBiryukov7 weeks ago

comment:6 SergeyBiryukov7 weeks ago

  • Milestone changed from Future Release to 3.9

26520.2.patch removes the title attribute from wp_widget_rss_output() and makes $summary assignment more consistent with $date and $author.

comment:7 nacin4 weeks ago

Keep in mind that wp_widget_rss_output() is used on the frontend. We *could* outright remove it, but rather than making such a decision late in a release, let's start by using the wp_html_excerpt()'d version as the title attribute, too, and omitting the title attribute if the summary is being shown.

comment:8 nacin4 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27691:

RSS widgets: Omit the title attribute when the summary is shown.

Trim the title attribute to ensure whitespace isn't rendered.

props SergeyBiryukov.
fixes #26520. see #26552.

Note: See TracTickets for help on using tickets.