WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26522 closed defect (bug) (fixed)

Before release: Change Twenty Fourteen headers

Reported by: pavelevap's profile pavelevap Owned by: nacin's profile nacin
Milestone: 3.8 Priority: high
Severity: major Version: 3.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

All default themes have specific Theme URI, related to their names.
But Twenty Fourteen has only ​http://wordpress.org/themes/

It is not big deal, because this URL is not usually localized, but translators will have one new empty string when this will be changed after release...

Attachments (1)

26522.diff​ (1.3 KB) - added by lancewillett 11 years ago.
Update Theme URI and bump version to 1.0

Download all attachments as: .zip

Change History (14)

#1 follow-up: @pavelevap
11 years ago

"Nothing Found" and "Not Found" can be combined into one string.

Now, there is no graphic difference, I guess :-)
Related: #24891

#2 @pavelevap
11 years ago

Tag name "featured" is not translatable? It should be, I guess...

#3 follow-up: @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Priority changed from normal to high
  • Severity changed from normal to major

I don't see a "featured" tag.

Moving the Theme URI change to 3.8. This is important because updates leverage this URI.

#4 @pavelevap
11 years ago

Tag slug "featured" is used for marking Featured content in Twenty Fourteen (you can see it in Customizer). But this does not mean anything for our language and users will be disappointed...

#6 @pavelevap
11 years ago

Tag slug "featured" should be definitely translatable.

And there is also related bug: When you change "featured" to for example "test", there are still links to "featured" tag in Help tab and Customizer.

#7 @lancewillett
11 years ago

  • Keywords has-patch added

Moved translation bug to #26526. I'm not sure it needs to be in 1.0 for Twenty Fourteen, can be done in 1.1 and pushed out in next minor release.

@lancewillett
11 years ago

Update Theme URI and bump version to 1.0

#8 in reply to: ↑ 1 @lancewillett
11 years ago

  • Keywords commit added

#9 follow-up: @pavelevap
11 years ago

I do not agree, it is not only translation, but also related bugs (hadrcoded "featured" links which does not work). Also minor release should not have string changes. And users updating to 3.8 will be asking why "featured". As a translator, I vote for doing it right now (even if there will be some string changes) and alarm Polyglots.

#10 in reply to: ↑ 9 @lancewillett
11 years ago

Replying to pavelevap:

I do not agree, it is not only translation, but also related bugs (hadrcoded "featured" links which does not work). Also minor release should not have string changes. And users updating to 3.8 will be asking why "featured". As a translator, I vote for doing it right now (even if there will be some string changes) and alarm Polyglots.

Please move comments to #26526 as that is a different ticket now.

#11 @nacin
11 years ago

  • Summary changed from Twenty Fourteen: Specific Theme URI to Before release: Change Twenty Fourteen headers

#12 @pavelevap
11 years ago

URI should be changed ASAP, because it is also string for localization.

#13 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26849:

Bump Twenty Fourteen to 1.0.

props lancewillett.
fixes #26522.

Note: See TracTickets for help on using tickets.