Twenty Fourteen: translate `featured` tag slug used to link to specific tags in Posts editor

[lancewillett]

Reported in #26522 by pavelevap.

[lancewillett]

Translate the featured tag with added context

[lancewillett]

In patch, I'm not sure if the extra esc_url() is needed since, but we should escape the translated tag somehow.

[lancewillett]

I vote we make this change for next minor release, 1.1 of the theme and in 3.8.1 of core.

[SergeyBiryukov]

Probably worth noting that we tend to avoid new translatable strings in minor releases.

[ocean90]

If we make it translatable we have to distinguish between tag name and tag slug. Since a translation can contain spaces (if two or more words) or have special characters which aren't allowed in a slug. Otherwise edit.php?tag=$name will fail for this translations.

Or change the context, to make it clear that the slug is meant.

[lancewillett]

Thanks obenland, patch .2 uses add_query_arg() to construct the URL and removes unneeded forward slash in the other admin_url() case.

[lancewillett]

Simplify things by not saying "featured" tag in any long strings, clean up Help text strings

[lancewillett]

Replying to ocean90:

Or change the context, to make it clear that the slug is meant.

Great point, fixed this in .3 patch.

[ocean90]

Use get_term_by( 'slug', ...

[ocean90]

26526.4.diff​ replaces get_term_by( 'name', with get_term_by( 'slug',.

[lancewillett]

Replying to ocean90:

26526.4.diff​ replaces get_term_by( 'name', with get_term_by( 'slug',.

I don't think we should change this. Searching by name is a better experience (even though in my own use case the slug and name are the same string, that's not the case with many authors.)

[obenland]

Replying to ocean90:

26526.4.diff​ replaces get_term_by( 'name', with get_term_by( 'slug',.

We're dealing with to different "states" here. In the links we use the slug, in the customizer default value and the Featured Content tag-name value, we use the name of the tag.

Additionally to what lancewillett mentioned above, the purpose of having a predefined tag is for the off chance that the user might have already posts with that tag. I'm really not sure that off chance will get much improvement if we translate it.

[ocean90]

Replying to obenland:

We're dealing with to different "states" here. In the links we use the slug, in the customizer default value and the Featured Content tag-name value, we use the name of the tag.

Correct, my mistake. Please ignore .4.diff. :)

[lancewillett]

Testing 26526.3.diff​ with es_ES MO/PO files — working as expected with Spanish destacado tag slug. Will attach file here in case anyone else wants to test with the same language files.

[lancewillett]

Spanish MO file for testing

[lancewillett]

Spanish PO file for testing

[lancewillett]

Noting we'll need a POT update as well if this goes in.

[nacin]

26526.3.diff​ looks good.

[lancewillett]

@nacin Can you push a new Twenty Fourteen POT after this is committed, please? I'll need it to package up a ZIP for WordPress.org directory.

[pavelevap]

It is a pitty, it should go into 3.8 :-(

Thinking about using "pre_option_featured-content" filter hack for our locale. It should work?

[lancewillett]

Related report in support forums: ​http://wordpress.org/support/topic/featured-in-translated-vesion

[obenland]

Since this would change defaults, it could break things if users have tagged posts with featured, relied on the defaults, and never saved the FC settings.

[lancewillett]

Discussing in bug scrub today in IRC. I think it's a needed change to improve international, non-English experience in this theme.

The trade-off is we'll break sites that have already tagged posts with featured tag and they update to this version and that tag is no longer the default in their language.

If we're OK with that breaking for those sites -- and if we communicate it clearly in the update notes to help people re-save their FC settings -- I think it should go in.

Note: patch .3 is the commit, not .4.

I'd like a 2nd opinion from core team. @nacin? @dh-shredder?

[lancewillett]

In 27122:

Twenty Fourteen: translate featured tag slug used to link to specific tags in Posts editor. See #26526.

[nacin]

lancewillett and I decided that we would be leaving all bundled theme tickets for 3.9. Given the timeline (and lack of severity) we won't be doing a theme update before then.