WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#26537 closed defect (bug) (fixed)

Toolbar icons overflow their container on small screen devices when multisite is enabled.

Reported by: iammattthomas Owned by: nacin
Milestone: 3.8.1 Priority: low
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

A late-breaking change before 3.8-RC2 changed the selector giving padding to toolbar items; it made it more specific at which point it began overriding the responsive styles. When I tested it on multisite today I noticed that the extra padding is forcing the My Account avatar out of the toolbar on iPhones and other narrow devices.

Attachments (3)

26537.diff (1.3 KB) - added by iammattthomas 5 years ago.
Adjusts widths of toolbar items at mobile sizes for better fitting on narrow screens.
before.png (23.0 KB) - added by iammattthomas 5 years ago.
after.png (23.0 KB) - added by iammattthomas 5 years ago.

Download all attachments as: .zip

Change History (10)

@iammattthomas
5 years ago

Adjusts widths of toolbar items at mobile sizes for better fitting on narrow screens.

@iammattthomas
5 years ago

@iammattthomas
5 years ago

#1 @nacin
5 years ago

  • Component changed from General to Administration
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.8
  • Priority changed from normal to high
  • Severity changed from normal to critical

#2 @nacin
5 years ago

  • Severity changed from critical to normal

This without a patch does not look nearly as bad as I had feared.

#3 @nacin
5 years ago

  • Priority changed from high to low

#4 @nacin
5 years ago

  • Milestone changed from 3.8 to 3.8.1

#5 @nacin
5 years ago

In 26920:

Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.

props iammattthomas.
see #26537 for trunk.

#6 @nacin
5 years ago

  • Keywords fixed-major added

#7 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26949:

Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.

Merges [26920] to the 3.8 branch.

props iammattthomas.
fixes #26537.

Note: See TracTickets for help on using tickets.