Page templates - localization does not work for 2014

[pavelevap]

I am not sure what can be wrong, but even if I translated Page Template name (Full Width Page), name is still in English in related dropdown.

It works with 2012, but does not work with 2014.

[SergeyBiryukov]

Confirmed. Caused by missing Text Domain declaration in style.css.

[pavelevap]

Good catch, I thought that I am crazy :-)

[nacin]

This is needed for translatable theme headers and theme language packs.

We should add a unit test to verify all themes have this header set.

[lancewillett]

I'll ping Otto to add this to Theme Check plugin blockers.

[nacin]

This is without a doubt a huge blocker.

For anyone that is running non-English and updates WordPress to 3.8, they won't be able to read Twenty Fourteen's description.

[knutsp]

I can confirm the issue and that the patch fixes it. But for the theme description, as nacin mentions, I can't get it translated to nb_NO no matter what I do (active/inactive, with or without the patch).

[lancewillett]

Theme description working correctly with es_ES.mo

[lancewillett]

With this patch applied I can see the theme description correctly translated in wp-admin/themes.php for currently active theme only, using ​{{{es_ES.mo}}} from GlotPress.

[matt]

We decided in the dev chat this is kosher for 3.8.0.

[matt]

In 26852:

We forgot the text domain, which made translation break. Fixes #26542.

Props SergeyBiryukov and pavelevap

[ocean90]

Replying to knutsp:

There was a string change in [26850].