Remove title attributes: media.php

[joedolson]

Related: #24766

// media.php
get_image_tag()

[joedolson]

Remove title attribute patch for wp-includes/media.php

[joedolson]

The only call to get_image_tag is in get_image_send_to_editor, which submits a blank string for the title attribute. Therefore, in get_image_tag, $title will never receive a value.

A title can still be added via the image_send_to_editor filter, but get_image_tag will still be irrelevant. Therefore, unless I'm missing something, it's totally reasonable to remove all references to $title in get_image_tag, adding documentation to the effect that it's been deprecated.

This is a simple patch, but it may be feasible to remove the attribute from the function arguments, as long as $title is declared and passed to the filter.

[nacin]

get_image_tag() almost had $title removed during the great Media Image Title Massacre of 3.5 (#18984). However, I realized it could easily be construed to be a utility function and that others may be using it with a tooltip. I think it's best to leave this one alone.

[joedolson]

Given that it is only likely to be used if somebody has specifically gone out of their way to implement it, it's probably fine to leave alone, as you say. Cheerio.