WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 6 months ago

#26550 new defect (bug)

Some anchor links should be buttons in media microtemplates

Reported by: joedolson Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: needs-patch
Focuses: accessibility Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// media-template.php
wp_print_media_templates()

Change History (8)

comment:1 @SergeyBiryukov15 months ago

  • Description modified (diff)

comment:2 @joedolson15 months ago

This file is filled with anchor elements with titles and no link text. Most of these links are probably functions that should be triggered by buttons, not links. (see #26504)

I can add screen-reader-text to all of the empty anchors, but I think I need to spend some more time with this and look at the alternatives before I can pull up a patch.

Opinions regarding how to best approach this are welcome.

comment:3 @joedolson15 months ago

  • Keywords 2nd-opinion added

comment:4 @nacin13 months ago

  • Component changed from Accessibility to Media
  • Focuses accessibility added

comment:5 @ericlewis9 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Version set to 3.5

Into it. Most of these you should be able to just switch out one for one with a <button> and move the title text to the innards. After we have it all functioning well we could talk about styling.

comment:7 @ericlewis9 months ago

  • Summary changed from Remove title attributes: media-template.php to Some anchor links should be buttons in media microtemplates

comment:8 @wonderboymusic6 months ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.