Some anchor links should be buttons in media microtemplates

[joedolson]

Related: #24766

// media-template.php
wp_print_media_templates()

[joedolson]

This file is filled with anchor elements with titles and no link text. Most of these links are probably functions that should be triggered by buttons, not links. (see #26504)

I can add screen-reader-text to all of the empty anchors, but I think I need to spend some more time with this and look at the alternatives before I can pull up a patch.

Opinions regarding how to best approach this are welcome.

[ericlewis]

Into it. Most of these you should be able to just switch out one for one with a <button> and move the title text to the innards. After we have it all functioning well we could talk about styling.

[ericlewis]

Related #23560

[afercia]

See related #32236 for the backbone-generated buttons.

[wonderboymusic]

I can change a few of the obvious ones

[wonderboymusic]

In 32467:

In media-template.php, change a few <a href="#" class="button">s to <button type="button" class="button" ...>.

See #26550.

[afercia]

In the proposed patch (first pass):

• all the non links are now buttons, except refresh-attachment which seems to be unused, will open a new ticket for this
• introduce a .button-link CSS class for a basic button reset, first pass
• JavaScript: the 'check' and 'close' icons (see screenshot) are now buttons, no need to attach a keydown event and no need for preventDefault()
• JavaScript: prevents toggleSelectionHandler to fire when activating the 'check' and 'close' buttons, fixes #32540
• translatable strings: updated the 'Remove' strings to be more descriptive when read out of context

[afercia]

• all the non links are now buttons, except refresh-attachment which seems to be unused, will open a new ticket for this

See #32550. Would greatly appreciate some devs eyes and possibly propose for commit consideration.

[wonderboymusic]

This looks good, I just need to spend more time with it

[wonderboymusic]

@afercia - can you do the string changes in a separate ticket? There is already a LOT going on here. I am going to add these pieces bit by bit

[afercia]

@wonderboymusic sure, will open a new ticket for the string changes

[afercia]

Related: #32792.

[wonderboymusic]

In 32952:

In Media microtemplates after [32467], use <button> instead of <a> for several more non-links.

Props afercia.
Fixes #26550.