Make WordPress Core

Opened 18 months ago

Last modified 13 days ago

#26550 assigned defect (bug)

Some anchor links should be buttons in media microtemplates

Reported by: joedolson Owned by: wonderboymusic
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: needs-patch
Focuses: accessibility Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// media-template.php

Change History (12)

comment:1 @SergeyBiryukov18 months ago

  • Description modified (diff)

comment:2 @joedolson18 months ago

This file is filled with anchor elements with titles and no link text. Most of these links are probably functions that should be triggered by buttons, not links. (see #26504)

I can add screen-reader-text to all of the empty anchors, but I think I need to spend some more time with this and look at the alternatives before I can pull up a patch.

Opinions regarding how to best approach this are welcome.

comment:3 @joedolson18 months ago

  • Keywords 2nd-opinion added

comment:4 @nacin16 months ago

  • Component changed from Accessibility to Media
  • Focuses accessibility added

comment:5 @ericlewis12 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Version set to 3.5

Into it. Most of these you should be able to just switch out one for one with a <button> and move the title text to the innards. After we have it all functioning well we could talk about styling.

comment:7 @ericlewis12 months ago

  • Summary changed from Remove title attributes: media-template.php to Some anchor links should be buttons in media microtemplates

comment:8 @wonderboymusic8 months ago

  • Milestone changed from Awaiting Review to Future Release

comment:9 @slackbot4 weeks ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.

comment:10 @afercia3 weeks ago

See related #32236 for the backbone-generated buttons.

comment:11 @wonderboymusic13 days ago

  • Milestone changed from Future Release to 4.3
  • Owner set to wonderboymusic
  • Status changed from new to assigned

I can change a few of the obvious ones

comment:12 @wonderboymusic13 days ago

In 32467:

In media-template.php, change a few <a href="#" class="button">s to <button type="button" class="button" ...>.

See #26550.

Note: See TracTickets for help on using tickets.