Remove title attributes: default-widgets.php

[joedolson]

Related: #24766

// default-widgets.php
widget()

[joedolson]

This needs more detail to be clear: references the widget method in WP_Widget_Meta, WP_Widget_RSS, and in wp_widget_rss_output().

This could stand some discussion. The title attributes are non-duplicates, but whether they are valuable is a different question. Removing the powered by attribute is probably something that should be discussed; but also the actual value of the various title attributes for feeds.

[SergeyBiryukov]

Related: #26520

[nacin]

In 27691:

RSS widgets: Omit the title attribute when the summary is shown.

Trim the title attribute to ensure whitespace isn't rendered.

props SergeyBiryukov.
fixes #26520. see #26552.

[UmeshSingla]

Replying to wonderboymusic:

RSS widgets: Omit the title attribute when the summary is shown seems to be already fixed in trunk.

Trim the title attribute to ensure whitespace isn't rendered is included in patch.

[UmeshSingla]

Trim the title in wp_widget_rss_output

[SergeyBiryukov]

Replying to UmeshSingla:

Trim the title attribute to ensure whitespace isn't rendered is included in patch.

That was a part of the commit message for the changeset linked above, [27691] (see line 871 there).

However, 26552.patch​ looks proper, I've included it in the patch on #28356.

[UmeshSingla]

Replying to SergeyBiryukov:

Replying to UmeshSingla:

Trim the title attribute to ensure whitespace isn't rendered is included in patch.

That was a part of the commit message for the changeset linked above, [27691] (see line 871 there).

However, 26552.patch​ looks proper, I've included it in the patch on #28356.

Yeah, I just checked it back. I might have got confused with $title as the value for title attribute and instead it uses $desc. Somehow $title also needs to be trimmed.

Thanks for including it in the patch.

[SergeyBiryukov]

As noted in comment:2, default-widgets.php still has title attributes in WP_Widget_Meta, WP_Widget_RSS, and wp_widget_rss_output(). We should review them and remove the ones that are not necessary.

[SergeyBiryukov]

Committed 26552.patch​ in [28586].

[wonderboymusic]

can someone review those remaining title="Sergey"s?

[joedolson]

With all of those remaining title attributes, the question in my mind is whether they provide any kind of necessary information.

WP_Widget_Meta:

Title attribute: "Syndicate this site using RSS 2.0"
Text: "Entries RSS"

Title attribute: "The latest comments to all posts in RSS"
Text: "Comments RSS"

In addition, the abbr element has a title attribute expanding the abbreviation, which I think should stay.

My question: Do the above title attributes really help anybody? If you don't know what RSS is, I don't think they explain it effectively, if you do, then they're completely unnecessary. On that basis, I'd vote for removal.

WP_Widget_RSS:

Title attribute: "Syndicate this content"
Text: Icon, alt "RSS"

As above, I don't think that this title attribute adds anything; same argument as above.

Title attribute: RSS feed description value
Text: RSS feed title value

In this case, I'm not clear why the description is just visible for everybody. This would be a major change, since it would require the description be made visible in the widget, but if it's important enough to show, it should be available to everybody.

wp_widget_rss_output():

I think we should eliminate this. If somebody has chosen an option to not show the summary, we should respect this, and remove the summary completely. I don't think it makes sense for somebody to choose to hide the summary, but still make it available to some users, just harder to get at.

[UmeshSingla]

Any thoughts @SergeyBiryukov, @wonderboymusic, what do we need what we don't?

[helen]

Uploaded a patch here for reference. There was one more title attribute I saw - the one on the WordPress.org link that says "Powered by WordPress, state-of-the-art semantic personal publishing platform.". I think it might be okay to leave that one, because the link text is just "WordPress.org". joedolson / a11y team, if you could just quickly evaluate the necessity of that final title attribute and comment here, then we can quickly commit and finish fixing this.

[joedolson]

Yes, I mentioned that in the original ticket, but just as "merits further discussion." From my view, it's not a necessary title attribute in any way; but from a branding perspective, I don't know how WP.org feels about that.

It's not disastrous to leave the occasional title attribute in place, but I don't think that the text adds very much, either.

[DrewAPicture]

@joedolson: What's left here? Is there a decision on what can stay and what can go?

[joedolson]

I think the patch as it is is good to go; the WP Powered by title attribute can stay.

[helen]

In 29338:

Remove remaining title attributes from default-widgets.php, with the exception of the one on the link to WordPress.org. fixes #26552.