WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 7 months ago

#26558 new defect (bug)

Remove title attributes: bookmark-template.php

Reported by: joedolson Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: 2nd-opinion has-patch needs-testing needs-refresh
Focuses: accessibility, template Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// bookmark-template.php
_walk_bookmarks()

Attachments (1)

26558.diff (790 bytes) - added by sharonaustin 17 months ago.
Added ARIA component

Download all attachments as: .zip

Change History (13)

comment:1 @SergeyBiryukov18 months ago

  • Description modified (diff)

comment:2 @joedolson18 months ago

Another one that adds additional info. Probably needs to be kept, but 2nd opinion welcome.

comment:3 @joedolson18 months ago

  • Keywords 2nd-opinion added

comment:4 @sharonaustin17 months ago

Joe, do you see any harm by modifying code to add "aria-describedby"? If not, I'd like to try to add a "patch" to this, mostly to learn the ropes of adding patches.

                $output .=  '<aria-describedby="bookmarklink"' . 'a href="' . $the_link . '"' . $rel . $title . $target . '>';

comment:5 @joedolson17 months ago

I don't see any harm in that, no - but the example you've provided won't work, because you've added the aria attribute before the element declaration; it needs to come after the 'a' reference.

Also, is 'bookmarklink' actually a unique ID for something? I wouldn't expect that to target something uniquely identifying; it seems generic.

So, in short, yes - feel free to add aria-describedby, but check your code!

comment:6 @sharonaustin17 months ago

Well, what do you know! I got to learn how to apply ARIA in the deal too! You're the greatest!

So, I was plain wrong about the location of where I put it--I appreciate the heads up--and the other thing I need to investigate a little further is the "ARIA DescribedBy" versus "ARIA Labeledby".....my understanding (very possibly erroneous here) is that ARIA described by "can" take an ID, but is not required to, and ARIA Labeledby MUST take an ID. I'll definitely revisit before submitting my "patch"

At any rate, I will revise code, and over break, put up a harmless "patch". Thanks again, and Merry Christmas.

comment:7 @sharonaustin17 months ago

I'm still working on this, but before I allow any of my own misconceptions about ARIA to spread, I want to confirm Joe Dolson was absolutely right. ID's are absolutely required for both ARIA-labeledby and ARIA-describedby.

Here's more information.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute

and

http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby

I'll be back for this; I am going to finish what I started here. But there's more to this than I first thought, and thank goodness Joe Dolson caught it. Thank you, Joe.

@sharonaustin17 months ago

Added ARIA component

comment:8 @sharonaustin17 months ago

  • Keywords has-patch needs-testing added

comment:9 @nacin16 months ago

  • Component changed from Accessibility to Template
  • Focuses accessibility added

comment:10 @nacin16 months ago

  • Component changed from Template to General
  • Focuses template added

comment:11 @wonderboymusic11 months ago

  • Milestone changed from Awaiting Review to Future Release

comment:12 @DrewAPicture7 months ago

  • Keywords needs-refresh added

Patch needs a refresh and should be generated from the WordPress root.

Note: See TracTickets for help on using tickets.