Make WordPress Core

Opened 10 years ago

Closed 9 years ago

Last modified 7 years ago

#26558 closed defect (bug) (wontfix)

Remove title attributes: bookmark-template.php

Reported by: joedolson's profile joedolson Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: close, title-attribute
Focuses: accessibility, template Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// bookmark-template.php

Attachments (1)

26558.diff (790 bytes) - added by sharonaustin 10 years ago.
Added ARIA component

Download all attachments as: .zip

Change History (16)

#1 @SergeyBiryukov
10 years ago

  • Description modified (diff)

#2 @joedolson
10 years ago

Another one that adds additional info. Probably needs to be kept, but 2nd opinion welcome.

#3 @joedolson
10 years ago

  • Keywords 2nd-opinion added

#4 @sharonaustin
10 years ago

Joe, do you see any harm by modifying code to add "aria-describedby"? If not, I'd like to try to add a "patch" to this, mostly to learn the ropes of adding patches.

                $output .=  '<aria-describedby="bookmarklink"' . 'a href="' . $the_link . '"' . $rel . $title . $target . '>';

#5 @joedolson
10 years ago

I don't see any harm in that, no - but the example you've provided won't work, because you've added the aria attribute before the element declaration; it needs to come after the 'a' reference.

Also, is 'bookmarklink' actually a unique ID for something? I wouldn't expect that to target something uniquely identifying; it seems generic.

So, in short, yes - feel free to add aria-describedby, but check your code!

#6 @sharonaustin
10 years ago

Well, what do you know! I got to learn how to apply ARIA in the deal too! You're the greatest!

So, I was plain wrong about the location of where I put it--I appreciate the heads up--and the other thing I need to investigate a little further is the "ARIA DescribedBy" versus "ARIA Labeledby" understanding (very possibly erroneous here) is that ARIA described by "can" take an ID, but is not required to, and ARIA Labeledby MUST take an ID. I'll definitely revisit before submitting my "patch"

At any rate, I will revise code, and over break, put up a harmless "patch". Thanks again, and Merry Christmas.

#7 @sharonaustin
10 years ago

I'm still working on this, but before I allow any of my own misconceptions about ARIA to spread, I want to confirm Joe Dolson was absolutely right. ID's are absolutely required for both ARIA-labeledby and ARIA-describedby.

Here's more information.


I'll be back for this; I am going to finish what I started here. But there's more to this than I first thought, and thank goodness Joe Dolson caught it. Thank you, Joe.

10 years ago

Added ARIA component

#8 @sharonaustin
10 years ago

  • Keywords has-patch needs-testing added

#9 @nacin
10 years ago

  • Component changed from Accessibility to Template
  • Focuses accessibility added

#10 @nacin
10 years ago

  • Component changed from Template to General
  • Focuses template added

#11 @wonderboymusic
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#12 @DrewAPicture
9 years ago

  • Keywords needs-refresh added

Patch needs a refresh and should be generated from the WordPress root.

#13 @afercia
9 years ago

  • Keywords close added; 2nd-opinion has-patch needs-testing needs-refresh removed

Since the Link Manager is now removed from new install and going to disappear, I'd propose to close this ticket.

#14 @joedolson
9 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Agreed. Closing.

#15 @afercia
7 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.