Remove title attributes: bookmark-template.php

[joedolson]

Related: #24766

// bookmark-template.php
_walk_bookmarks()

[joedolson]

Another one that adds additional info. Probably needs to be kept, but 2nd opinion welcome.

[sharonaustin]

Joe, do you see any harm by modifying code to add "aria-describedby"? If not, I'd like to try to add a "patch" to this, mostly to learn the ropes of adding patches.

                $output .=  '<aria-describedby="bookmarklink"' . 'a href="' . $the_link . '"' . $rel . $title . $target . '>';

[joedolson]

I don't see any harm in that, no - but the example you've provided won't work, because you've added the aria attribute before the element declaration; it needs to come after the 'a' reference.

Also, is 'bookmarklink' actually a unique ID for something? I wouldn't expect that to target something uniquely identifying; it seems generic.

So, in short, yes - feel free to add aria-describedby, but check your code!

[sharonaustin]

Well, what do you know! I got to learn how to apply ARIA in the deal too! You're the greatest!

So, I was plain wrong about the location of where I put it--I appreciate the heads up--and the other thing I need to investigate a little further is the "ARIA DescribedBy" versus "ARIA Labeledby".....my understanding (very possibly erroneous here) is that ARIA described by "can" take an ID, but is not required to, and ARIA Labeledby MUST take an ID. I'll definitely revisit before submitting my "patch"

At any rate, I will revise code, and over break, put up a harmless "patch". Thanks again, and Merry Christmas.

[sharonaustin]

I'm still working on this, but before I allow any of my own misconceptions about ARIA to spread, I want to confirm Joe Dolson was absolutely right. ID's are absolutely required for both ARIA-labeledby and ARIA-describedby.

Here's more information.

​https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute

and

​http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby

I'll be back for this; I am going to finish what I started here. But there's more to this than I first thought, and thank goodness Joe Dolson caught it. Thank you, Joe.

[sharonaustin]

Added ARIA component

[DrewAPicture]

Patch needs a refresh and should be generated from the WordPress root.

[afercia]

Since the Link Manager is now removed from new install and going to disappear, I'd propose to close this ticket.

[joedolson]

Agreed. Closing.