WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#26561 closed defect (bug) (fixed)

Remove title attributes: general-template.php

Reported by: joedolson Owned by: SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch, title-attribute
Focuses: accessibility, template Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// general-template.php
get_calendar()

Attachments (1)

26561.patch (1.7 KB) - added by joedolson 7 years ago.
Remove title attribute for general-template.php

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)

#2 @joedolson
7 years ago

What I'd like to change in this, in addition to the prev/next links handled in the attached patch, is the <th> title for day names. That should really be an <abbr> element wrapping the day name, rather than a title on the table heading cell. That would potentially have an impact on output, so probably should be discussed.

I left the title attributes on the day links with post titles, because that seems like valuable added information. Usual caveat, should be expressed in an accessible way, etc., but still needs to be provided.

#3 @joedolson
7 years ago

  • Keywords has-patch 2nd-opinion added

@joedolson
7 years ago

Remove title attribute for general-template.php

#4 @nacin
7 years ago

  • Component changed from Accessibility to Template
  • Focuses accessibility added

#5 @nacin
7 years ago

  • Component changed from Template to Posts, Post Types
  • Focuses template added

This ticket was mentioned in IRC in #wordpress-dev by jessepollak. View the logs.


7 years ago

#7 @wonderboymusic
7 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 4.0

#8 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29244:

Remove redundant title attributes from get_calendar().

props joedolson.
fixes #26561.

#9 @afercia
4 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.