Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#26565 closed task (blessed) (fixed)

revisions.js routing doesn't actually do anything. Remove dead code.

Reported by: markjaquith Owned by: nacin
Milestone: 3.9 Priority: low
Severity: trivial Version: 3.6
Component: Revisions Keywords: has-patch dev-feedback needs-testing
Focuses: Cc:


matveb and adamsilverstein pointed out to me that the revisions.js routing doesn't actually do anything because Backbone doesn't support parsing of query args. The reason that it works is that we're pre-populating the variables in PHP and handing them off to the JS. So the routes and their callback are dead code that can just be removed.

Attachments (1)

26565.diff (1.1 KB) - added by adamsilverstein 23 months ago.
remove unused router code

Download all attachments as: .zip

Change History (6)

23 months ago

remove unused router code

#1 @adamsilverstein
23 months ago

  • Cc adamsilverstein@… added
  • Keywords has-patch dev-feedback added

26565.diff​ removed routing code that is no longer used

#2 @nacin
23 months ago

  • Milestone changed from Awaiting Review to 3.9

#3 @adamsilverstein
23 months ago

  • Keywords needs-testing added

I tested and would appreciate anyone who can pitch in here with a sanity check to double check this change doesn't break anything unexpectedly, throw console errors, etc.

#4 @kovshenin
23 months ago

Looks sane. Tested in Chrome and Firefox on OS X.

#5 @nacin
21 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27273:

Remove unused routing code in revisions.

props adamsilverstein.
fixes #26565.

Note: See TracTickets for help on using tickets.