Opened 11 years ago
Closed 11 years ago
#26565 closed task (blessed) (fixed)
revisions.js routing doesn't actually do anything. Remove dead code.
Reported by: | markjaquith | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.9 | Priority: | low |
Severity: | trivial | Version: | 3.6 |
Component: | Revisions | Keywords: | has-patch dev-feedback needs-testing |
Focuses: | Cc: |
Description
matveb and adamsilverstein pointed out to me that the revisions.js routing doesn't actually do anything because Backbone doesn't support parsing of query args. The reason that it works is that we're pre-populating the variables in PHP and handing them off to the JS. So the routes and their callback are dead code that can just be removed.
Attachments (1)
Change History (6)
#1
@
11 years ago
- Cc adamsilverstein@… added
- Keywords has-patch dev-feedback added
26565.diff removed routing code that is no longer used
Note: See
TracTickets for help on using
tickets.
remove unused router code