WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#26566 closed task (blessed) (fixed)

Add unit test to verify all bundled themes have valid text domain declared

Reported by: markjaquith Owned by: nacin
Milestone: 3.9 Priority: high
Severity: normal Version: 3.8
Component: Unit Tests Keywords:
Focuses: Cc:

Description

#26542 was embarrassing — we almost released Twenty Fourteen without a text domain declared for it. Let's set up a unit test to make sure this never happens again.

Change History (4)

#1 @nacin
5 years ago

Would benefit from public exposure of WP_Theme::$_default_themes.

#2 @nacin
5 years ago

Or can just do a hardcoded array and also fail the test if WP_DEFAULT_THEME is not in the array, which would cause us to update it.

#3 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26858:

Add unit test to verify all bundled themes have valid text domain declared.

fixes #26566.

#4 @ocean90
4 years ago

  • Milestone changed from Awaiting Review to 3.9
Note: See TracTickets for help on using tickets.