wp_set_object_terms - bug

[stiofansisland]

wp_set_object_terms claims to be able to use a term's ID or slug when in fact it will only use slug, trying to use a category ID will create a new numerical category and assign that.
​http://codex.wordpress.org/Function_Reference/wp_set_object_terms

[helen]

Actually, hierarchical taxonomies need the ID, non-hierarchical expect the slug. Sounds like the inline docs need an update, though.

[stiofansisland]

Replying to helen:

Actually, hierarchical taxonomies need the ID, non-hierarchical expect the slug. Sounds like the inline docs need an update, though.

OK i went and did some digging and found the root of the problem, function term_exists checks the term to see if it's an int or a slug, the problem is it uses "is_int" which being that the majority of people using this function in the wild will be posting the term value is_int sees any POST value as a string so it then moves on to query the ID as a term which breaks.

I propose to fix this we change taxonomy.php line: 1570

FROM:

if ( is_int($term) ) {

TO:

if ( is_numeric($term) ) {

Thanks,

Stiofan

[SergeyBiryukov]

Replying to stiofansisland:

I propose to fix this we change taxonomy.php line: 1570

See #18009.

[DrewAPicture]

Replying to helen:

Actually, hierarchical taxonomies need the ID, non-hierarchical expect the slug. Sounds like the inline docs need an update, though.

Not sure I'm following which inline docs need to change -- do you mean to specify which type should be passed for hierarchical vs non-hierarchical?

Happy to patch whatever needs patching, just need a clarification.

[helen]

Replying to DrewAPicture:

Not sure I'm following which inline docs need to change -- do you mean to specify which type should be passed for hierarchical vs non-hierarchical?

Yeah, I think that's what I meant. Also the Codex, I suppose.

[DrewAPicture]

See comment:5

[wonderboymusic]

This probably needs docs fixes, but no one has done them yet

[DrewAPicture]

After reviewing this again, I don't think any changes are warranted here. It actually seems to be a pretty close duplicate to #18009.

[wonderboymusic]

We need unit tests that have all of the different permutations represented

[DrewAPicture]

Docs update

[DrewAPicture]

26570.diff​ updates the parameter description for $terms:

A single term slug (if the taxonomy is hierarchical), single term id, or array of either term slugs or ids. Will replace all existing related terms in this taxonomy.

[DrewAPicture]

s/taxonomies/term's

[DrewAPicture]

+ unit tests

[DrewAPicture]

26570.2.diff​ adds unit tests for inserting a term by ID, by slug, by an array of IDs, and by an array of slugs per comment:10.

[SergeyBiryukov]

The main point of this ticket was fixed in #17646.

A single term slug (if the taxonomy is hierarchical)

This appears to contradict comment:1. I don't think it actually matters if the taxonomy is hierarchical or not, both the term ID and the term slug should work regardless. I've expanded the unit tests to demonstrate that.

We already have tests for wp_set_object_terms​, and there's some overlap between the old and new ones, but I guess adding more wouldn't hurt.

To summarize, there are no significant changes here, we just clarify the docs a bit and add some more unit tests.

[SergeyBiryukov]

In 28951:

Clarify the docs and add more unit tests for wp_set_object_terms().

props DrewAPicture.
fixes #26570.

[DrewAPicture]

In 28952:

Fix parameter description for $append in wp_set_object_terms() inline docs.

See #26570.

[SergeyBiryukov]

In 28953:

Reorder test functions in term.php for consistency. Add @ticket references.

see #26570.