Dashboard shows inaccessible links for Authors and Contributors

[johnbillion]

The "At a Glance" dashboard widget show "X Posts", "X Pages" and "X Comments" with links to the corresponding listing screens, but there are no capability checks in place when the links are output. This means Author level users see a link to the Pages screen that they don't have access to, and Contributors see a link to the Posts, Comments and Pages screens, none of which they have access to.

In 3.7 and earlier, if the user didn't have the capability to edit the object then the text was shown without a link.

Previously: #26495, #25824

[johnbillion]

Note that the CSS for the icons on these links relies on there being an a tag present. That'll need changing too.

[johnbillion]

Actually we might as well just not show the items that the user cannot edit.

[mattheu]

Patch added

[helen]

What are we thinking here? Unlinked text (as previously) or just hide the item altogether?

[johnbillion]

Hide them I think. Not a lot of value in displaying the count for something the user can't access.

[nacin]

Replying to johnbillion:

Hide them I think. Not a lot of value in displaying the count for something the user can't access.

While there's nothing wrong with hiding them, I wonder if there will be much for low-level users to be able to get a "glance" of.

At the same time, one could argue there's not a whole lot of value for displaying many of these counts to anyone, which is partially why there are less numbers just randomly tossed onto the dashboard now.

Let's remove them for now (and for 3.8.1), to remove the broken links. But worth future consideration.

johnbillion, up for running with this?

[nacin]

In 26999:

Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.

props mattheu.
see #26574 for trunk.

[nacin]

[26999] seemed like the best compromise for the 3.8 branch, given it keeps the UI change small, and also is a bit more consistent with 3.7.

[nacin]

In 27001:

Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.

Merges [26999] to the 3.8 branch.

props mattheu.
fixes #26574.