WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Last modified 6 years ago

#26596 new defect (bug)

Edit comments from wpAdmin don't process well radio button fields

Reported by: corretge's profile corretge Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Comments Keywords: has-patch needs-refresh
Focuses: Cc:

Description

I'm filtering for 'wp_comment_reply' to add a custom radio button selector in the wpAdmin comments.

Then the ajax request don't send this field value, always send the last one, checked or not.

wp-admin/js/edit-comments.js process all INPUT fields as a text (except type button)

I attach the patch to allow radio buttons but doesn't works for checkbox.

Attachments (1)

wp_allow_radio_repy_comments.diff​ (719 bytes) - added by corretge 11 years ago.
allow radio buttons on wpAdmin comments

Download all attachments as: .zip

Change History (5)

@corretge
11 years ago

allow radio buttons on wpAdmin comments

#1 @SergeyBiryukov
11 years ago

  • Version changed from trunk to 2.7

Introduced in [8720].

#2 @chriscct7
9 years ago

  • Keywords has-patch needs-refresh added

Patch needs to be reformatted to follow core code standards

This ticket was mentioned in ​Slack in #core-comments by rachelbaker. ​View the logs.
9 years ago

#4 @rachelbaker
9 years ago

  • Milestone changed from Awaiting Review to Future Release

Our current form processing only handles the text and hidden inputs, custom inputs of other field types would require custom code. I don't think we should include an enhancement for handling any other input type that could be added via a hook.

Moved to "Future Release" to fix the greedy input selector used in commentReply.send to only text or hidden fields.

Note: See TracTickets for help on using tickets.